rules icon indicating copy to clipboard operation
rules copied to clipboard

Duplicated entries across various `falco` rules files

Open leogr opened this issue 2 years ago • 15 comments

Motivation

See https://github.com/falcosecurity/rules/pull/149#issuecomment-1705527047

The common use case is when a list or a macro is first defined in the stable rules file, but it is also needed (as-is or extended) by other rules files.

Feature

Likely, the simplest way to address this is to define a standard way to express list and macro dependencies requirements.

This would force the user to load another rules file with the missing list or macro definition, without the need of duplicating the whole list or macro.

However, the design of this feature is still TBD

@falcosecurity/core-maintainers

Alternatives

Keep duplicate entries, as it is now. In this way, duplicated items are just silently overwritten. The only con is that the loading order affects the end results when the duplicate item is not identical (for example, if it has been modified in one file but not in the other).

Additional context

See https://github.com/falcosecurity/rules/pull/149#issuecomment-1705527047

leogr avatar Sep 04 '23 16:09 leogr

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

poiana avatar Dec 03 '23 21:12 poiana

/remove-lifecycle stale

leogr avatar Dec 05 '23 17:12 leogr

/assign

leogr avatar Dec 05 '23 17:12 leogr

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

poiana avatar Mar 04 '24 21:03 poiana

/remove-lifecycle stale

still relevant

incertum avatar Mar 05 '24 00:03 incertum

cc @falcosecurity/falco-maintainers

leogr avatar Mar 26 '24 15:03 leogr

Likely, the simplest way to address this is to define a standard way to express list and macro dependencies requirements.

It makes the most sense. Worth it the transition LOE I would say. Not having any better ideas. Right now for example I dedup the macros and lists in a custom patch script, but there are adopters who wish to not needing to use a custom patch script.

incertum avatar Mar 27 '24 15:03 incertum

Just as a reference. The new idiomatic way to express "this list is defined somewhere else - ie, in another file" would now be:

- list: foo
  items: []
  override:
      - items: append

leogr avatar May 14 '24 09:05 leogr

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

poiana avatar Aug 12 '24 10:08 poiana

/remove-lifecycle stale /help

leogr avatar Aug 20 '24 12:08 leogr

@leogr: This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-help command.

In response to this:

/remove-lifecycle stale /help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

poiana avatar Aug 20 '24 12:08 poiana

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

poiana avatar Nov 18 '24 16:11 poiana

/remove-lifecycle stale

leogr avatar Nov 18 '24 16:11 leogr

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

poiana avatar Apr 16 '25 16:04 poiana

/remove-lifecycle stale

leogr avatar Apr 17 '25 08:04 leogr