plugin-sdk-go icon indicating copy to clipboard operation
plugin-sdk-go copied to clipboard

Add internal logging system

Open jasondellaluce opened this issue 4 years ago • 32 comments

Motivation Currently, the SDK does not have an embedded logging system. This could be useful for debugging plugins during the development phase and in many other use cases. Currently this is attained manually in each plugin (see an example).

Feature Add some standard Go logging system in the SDK, such as https://pkg.go.dev/log. Plugins must be able to enable/disable and configure the logger programmatically.

The logging system could be bundled in the base level sdk package, but we can also consider creating an single-reposibility log package, just like we have ptr and cgo. Then, each internal part of the SDK should rely on that to log information with different severity level. For instance, each prebuilt C symbol should log meaningful information, and constructs such as EventWriters can potentially log something too.

Alternatives Leave things as they are, meaning that user each plugin should implement their logging measures. I don't like this option, especially because it makes not possible for the SDK to expose some of its internal process, which can be meaningful for debugging purposes.

jasondellaluce avatar Nov 11 '21 09:11 jasondellaluce

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

poiana avatar Feb 09 '22 10:02 poiana

/remove-lifecycle stale

jasondellaluce avatar Feb 10 '22 12:02 jasondellaluce

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

poiana avatar May 11 '22 18:05 poiana

Stale issues rot after 30d of inactivity.

Mark the issue as fresh with /remove-lifecycle rotten.

Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle rotten

poiana avatar Jun 10 '22 18:06 poiana

Rotten issues close after 30d of inactivity.

Reopen the issue with /reopen.

Mark the issue as fresh with /remove-lifecycle rotten.

Provide feedback via https://github.com/falcosecurity/community. /close

poiana avatar Jul 10 '22 21:07 poiana

@poiana: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue with /reopen.

Mark the issue as fresh with /remove-lifecycle rotten.

Provide feedback via https://github.com/falcosecurity/community. /close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

poiana avatar Jul 10 '22 21:07 poiana

/reopen

/remove-lifecycle rotten

jasondellaluce avatar Jul 11 '22 05:07 jasondellaluce

@jasondellaluce: Reopened this issue.

In response to this:

/reopen

/remove-lifecycle rotten

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

poiana avatar Jul 11 '22 05:07 poiana

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

poiana avatar Oct 12 '22 15:10 poiana

/remove-lifecycle stale

jasondellaluce avatar Oct 12 '22 16:10 jasondellaluce

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

poiana avatar Jan 10 '23 21:01 poiana

Stale issues rot after 30d of inactivity.

Mark the issue as fresh with /remove-lifecycle rotten.

Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle rotten

poiana avatar Feb 09 '23 21:02 poiana

/remove-lifecycle rotten

jasondellaluce avatar Feb 10 '23 10:02 jasondellaluce

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

poiana avatar May 11 '23 13:05 poiana

/remove-lifecycle stale

Andreagit97 avatar May 11 '23 14:05 Andreagit97

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

poiana avatar Aug 09 '23 19:08 poiana

/remove-lifecycle stale

Andreagit97 avatar Aug 09 '23 20:08 Andreagit97

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

poiana avatar Nov 07 '23 21:11 poiana

Stale issues rot after 30d of inactivity.

Mark the issue as fresh with /remove-lifecycle rotten.

Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle rotten

poiana avatar Dec 07 '23 21:12 poiana

/remove-lifecycle rotten

Andreagit97 avatar Dec 11 '23 10:12 Andreagit97

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

poiana avatar Mar 10 '24 15:03 poiana

@jasondellaluce I am also interested in this issue! I like to work on this if it is available

GLVSKiriti avatar Mar 23 '24 11:03 GLVSKiriti

Yeah definitely, let me assign you to this one. Note that the latest plugin API provides logging primitives -- take a look at the work we did for the SDK C++: https://github.com/falcosecurity/plugin-sdk-cpp/pull/35

/assign GLVSKiriti

jasondellaluce avatar Mar 25 '24 13:03 jasondellaluce

/remove-lifecycle stale

leogr avatar Mar 26 '24 16:03 leogr

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

poiana avatar Jun 24 '24 21:06 poiana

Any update on this? :thinking:

leogr avatar Jun 26 '24 15:06 leogr

Stale issues rot after 30d of inactivity.

Mark the issue as fresh with /remove-lifecycle rotten.

Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle rotten

poiana avatar Jul 26 '24 16:07 poiana

/remove-lifecycle rotten /remove-lifecycle stale

leogr avatar Jul 30 '24 15:07 leogr