libs
libs copied to clipboard
falcosecurity
Use same version in all cmake_minimum_required() statements
What type of PR is this?
/kind cleanup /release-note-none
Any specific area of the project related to this PR?
/area build
What this PR does / why we need it:
The project libs declares in several CMake files the required version of CMake.
cmake_minimum_required(VERSION 3.5.1)
The values for the version are all different (2.8.2, 2.8.5, 3.5.1). The change aims at making the older ones uniform to the latest of the three, 3.5.1. This should also avoid some warnings that come up with newer versions of CMake. Moreover this version is the one already used in project falco (https://github.com/falcosecurity/falco.git).
Does this PR introduce a user-facing change?:
NONE
@federico-sysdig: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Welcome @federico-sysdig! It looks like this is your first PR to falcosecurity/libs 🎉
The problem with these changes is that bumping the CMake version in some files the behavior of the CMake code changes and as you can see the tests are failing :(
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: federico-sysdig
Once this PR has been reviewed and has the lgtm label, please assign fededp for approval by writing /assign @fededp in a comment. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
@federico-sysdig: Adding label do-not-merge/contains-merge-commits because PR contains merge commits, which are not allowed in this repository.
Use git rebase to reapply your commits on top of the target branch. Detailed instructions for doing so can be found here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle stale
