libs icon indicating copy to clipboard operation
libs copied to clipboard

Published 20 hours ago • verified publisher icon falcosecurity

docs(ringbuffer): add some documentation around perf buffer logic

Open Andreagit97 opened this issue 3 years ago • 2 comments

What type of PR is this?

/kind cleanup

/kind documentation

Any specific area of the project related to this PR?

/area driver-kmod

/area driver-bpf

Does this PR require a change in the driver versions?

No

What this PR does / why we need it:

This PR adds some documentation around the BPF perf buffer reading phase, these comments are also strictly related to how we read data with the kmod since almost all the code is shared!

We also rename a variable from max_ts to min_ts since it seems a most reasonable name :)

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Andreagit97 avatar Sep 24 '22 13:09 Andreagit97

LGTM label has been added.

Git tree hash: 0ce4c4be6873b19f6ce9dd3f940a81edccb0abba

poiana avatar Oct 13 '22 08:10 poiana

/hold

Andreagit97 avatar Oct 21 '22 09:10 Andreagit97

/milestone 0.10.0

Andreagit97 avatar Oct 28 '22 18:10 Andreagit97

LGTM label has been added.

Git tree hash: 23efacb42fe84a8d0749899c1285551a6c8e271f

poiana avatar Nov 07 '22 13:11 poiana

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [Andreagit97,FedeDP,leogr]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

poiana avatar Nov 07 '22 13:11 poiana

/unhold

Andreagit97 avatar Nov 07 '22 13:11 Andreagit97