libs icon indicating copy to clipboard operation
libs copied to clipboard

wip: update(userspace/plugin): bump plugin API version to 1.1.0

Open jasondellaluce opened this issue 3 years ago • 3 comments

What type of PR is this?

/kind documentation

/kind feature

Any specific area of the project related to this PR?

/area API-version

Does this PR require a change in the driver versions?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Linked to https://github.com/falcosecurity/falco/issues/2074, this updates the plugin API to regulate and document the concurrency constraints of the API symbols. Few outdated descriptions have been updated too.

This changes require a minor API version bump to 1.1.0, because this doesn't introduce a breaking change (older frameworks will still load the concurrency-compliant new plugins).

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

update(userspace/plugin): bump plugin API version to 1.1.0

jasondellaluce avatar Aug 11 '22 13:08 jasondellaluce

@jasondellaluce: The label(s) area/api-version cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

/kind documentation

/kind feature

Any specific area of the project related to this PR?

/area API-version

Does this PR require a change in the driver versions?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Linked to https://github.com/falcosecurity/falco/issues/2074, this updates the plugin API to regulate and document the concurrency constraints of the API symbols. Few outdated descriptions have been updated too.

This changes require a minor API version bump to 1.1.0, because this doesn't introduce a breaking change (older frameworks will still load the concurrency-compliant new plugins).

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

update(userspace/plugin): bump plugin API version to 1.1.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

poiana avatar Aug 11 '22 13:08 poiana

/milestone 0.9.0

Andreagit97 avatar Aug 11 '22 16:08 Andreagit97

Actually, we need to bump to 2.0.0 to properly prevent old plugins to be loaded in newer versions of the framework. This is needed to avoid data races on old plugins that don't support concurrency.

jasondellaluce avatar Aug 22 '22 09:08 jasondellaluce

LGTM label has been added.

Git tree hash: 692bc0ef363f53a0130790c96116937454b6c675

poiana avatar Aug 22 '22 09:08 poiana

/hold

Andreagit97 avatar Aug 22 '22 09:08 Andreagit97

Holding this until we have stable support for multi-source in Falco and we know for sure that these docs are enough for the requirements. At the same time, we delay breaking changes on master for existing released plugins.

jasondellaluce avatar Aug 22 '22 13:08 jasondellaluce

LGTM label has been added.

Git tree hash: 2dd155037ccdcb86801f2395ca4a12de8a4c2e51

poiana avatar Sep 06 '22 14:09 poiana

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, jasondellaluce, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [Andreagit97,leogr]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

poiana avatar Sep 06 '22 16:09 poiana

/unhold

leogr avatar Sep 06 '22 16:09 leogr