libs
libs copied to clipboard
falcosecurity
Makefile for scap_open test
What type of PR is this?
Uncomment one (or more)
/kind <>lines:
/kind feature
Any specific area of the project related to this PR?
Uncomment one (or more)
/area <>lines:
/area libscap
/area tests
What this PR does / why we need it:
Add another ability to build scap_open test via makefile
Which issue(s) this PR fixes:
https://github.com/falcosecurity/libs/issues/482
Fixes #
Special notes for your reviewer:
First of all need to build scap libraries (using existing cmake) and then you can to build scap_open test by using the makefile instead of CMakeList.
Does this PR introduce a user-facing change?:
NONE
Welcome @liorzemah! It looks like this is your first PR to falcosecurity/libs 🎉
Hi @liorzemah. Thanks for your PR.
I'm waiting for a falcosecurity member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: liorzemah
To complete the pull request process, please assign fntlnz after the PR has been reviewed.
You can assign the PR to them by writing /assign @fntlnz in a comment when ready.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Thank you for this @liorzemah!! The DCO is missing, you need to merge the PR, if you have problems in doing this feel free to ask :)
Nice, thank you @liorzemah! It LGTM! It would be amazing if you could add just 2 lines in the scap-open README.md (maybe in a new dedicated section Build with Makefile) in which you explain the necessary steps to use this makefile cloning the libs repository from scratch. In this way also other folks would benefit from this amazing contribution. WDYT @FedeDP @Molter73 @liorzemah?
LGTM label has been added.
/hold
Pr #546 adds support for pkg-config files. I think this PR will be useless once we properly install pkg-config scripts.
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle stale
Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle rotten
Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Provide feedback via https://github.com/falcosecurity/community. /close
@poiana: Closed this PR.
In response to this:
Rotten issues close after 30d of inactivity.
Reopen the issue with
/reopen.Mark the issue as fresh with
/remove-lifecycle rotten.Provide feedback via https://github.com/falcosecurity/community. /close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.