BigInt

BigInt copied to clipboard

Elaborate instructions on which files to #include for which functions/operators

2

The README states that you only have to `#include` a single header file. That's not true. You also have to include one or more header files from the directories below...

607011

BigInt problem with hexdigit string

1

BigInt header only does not work with hexdigit string like std::string hexStr = "123456789abcdef123456789abcdef"; It is very kind of you to extend it. Best thanks

Thanh-Binh

Invalid string access on modulo

2

The following modulo computation causes an invalid string access in the library: ```cpp #include "BigInt.hpp" #include int main() { BigInt number("12345678901234567890123456789012345678901234567889"); std::cout

mristin

Thank you very much for such a nice library! I had to integrate it in a project running on Windows. A couple of places had to be fixed since MSVC...

mristin

The BigInt relational operators, for example `BigInt::operator>` are not optimal. Currently, the code is: ``` bool BigInt::operator>(const BigInt& num) const { return !((*this < num) or (*this == num)); }...

dynarithmic

The old one will fail if base==-1 && exp is even, and the result should be 1 instead of -1.

HUGHNew

Fixes #76 Removed unnecessary calls to other operators.

itstrueitstrueitsrealitsreal