ParlAI icon indicating copy to clipboard operation
ParlAI copied to clipboard

Published 20 hours ago • verified publisher icon facebookresearch

replace fuzzywuzzy with rapidfuzz

Open maxbachmann opened this issue 3 years ago • 1 comments

Patch description Fuzzywuzzy is GPL licensed, so this PR replaces it with rapidfuzz which is MIT licensed. As a side effect this is much faster, but I do not know whether this is of any relevance in this code section.

Testing steps The behavior should not change.

Other information

maxbachmann avatar Oct 31 '22 13:10 maxbachmann

Thanks for the PR, could you also please update the cache keys for our CI?

CC @moyapchen as this is TOD-related (lmk if someone else is better suited for review)

klshuster avatar Nov 04 '22 16:11 klshuster

This PR has not had activity in 30 days. Closing due to staleness.

github-actions[bot] avatar Dec 07 '22 00:12 github-actions[bot]

@klshuster @moyapchen Is there anything still needed to do from my side?

maxbachmann avatar Dec 07 '22 17:12 maxbachmann

think this all looks good on my end but will defer to @moyapchen for final approval

klshuster avatar Dec 07 '22 17:12 klshuster

This PR has not had activity in 30 days. Closing due to staleness.

github-actions[bot] avatar Jan 08 '23 00:01 github-actions[bot]

@klshuster @moyapchen is there still interest in this?

maxbachmann avatar Jan 16 '23 01:01 maxbachmann

yes! could you please update the cache keys one more time?

klshuster avatar Jan 18 '23 15:01 klshuster

Whoops - well, I apparently completely and utterly failed to notice this PR's existence.

This code is was being used for some of the applied research teams, but I'm pretty sure they've moved far beyond using this teacher a while back, so happy to accept.

moyapchen avatar Jan 18 '23 16:01 moyapchen

This PR has not had activity in 30 days. Closing due to staleness.

github-actions[bot] avatar Feb 18 '23 00:02 github-actions[bot]