velox icon indicating copy to clipboard operation
velox copied to clipboard

Published 20 hours ago • verified publisher icon facebookincubator

Merge Join generating invalid vector

Open pedroerp opened this issue 1 year ago • 1 comments

Bug description

Depending on the output buffer alignment, the existing merge join code tries to create an invalid dictionary (more rows than indices), if left join and filters are enabled.

To reproduce, simply set the output buffer size to 1000 here:

https://github.com/facebookincubator/velox/blob/main/velox/exec/tests/MergeJoinTest.cpp#L580

(replace the plan parameter to makeCursorParameters(plan, 1000))

System information

any

Relevant logs

just run the unit test

pedroerp avatar May 10 '24 18:05 pedroerp

This looks like a problem similar to https://github.com/facebookincubator/velox/pull/6680

CC: @kevinwilfong @xiaoxmeng

mbasmanova avatar May 13 '24 14:05 mbasmanova

Fixed in https://github.com/facebookincubator/velox/pull/9862

pedroerp avatar Jun 01 '24 18:06 pedroerp