Bowler icon indicating copy to clipboard operation
Bowler copied to clipboard

Better error checking when calling filename_matcher

Open thatch opened this issue 6 years ago • 4 comments

Right now it looks like any exception causes a hang.

thatch avatar May 13 '19 20:05 thatch

Hey @thatch! Can you share more information on the error? I am a first time contributor. And I would love to give it a try.

akash-suresh avatar May 16 '20 12:05 akash-suresh

Sure! Using a bowler script something like sample.py

from bowler import Query

def filename_matcher(*args):
  raise Exception()

Query(["."], filename_matcher=filename_matcher).diff()

and run with

bowler run sample.py

It should print the exception once per file, and exit. Right now it causes a hang. @jreese any further advice?

thatch avatar May 21 '20 18:05 thatch

Is this issue still open? If its open I would like to contribute

MadhuMPandurangi avatar Jan 22 '23 05:01 MadhuMPandurangi