sapling ReviewStack versions are confusing?

I made a stack with 2 commits. I pulled from master, rebased against it, then made a change on the 2nd commit.

When viewing ReviewStack on the 2nd PR, on the sidebar to the right, I can see 3 versions, but the Version select at the top still says "V1". The diff section shows code as it existed at V1, not V3.

Am I doing something wrong?

Nov 17 '22 18:11 francois

@francois I definitely have to clean up somethings here. Out of curiosity, did you use sl pr or sl ghstack?

Nov 19 '22 00:11 bolinfest

I used sl pr, @bolinfest.

Nov 19 '22 12:11 francois

Possibly related: https://github.com/facebook/sapling/issues/587

Apr 21 '23 22:04 kalaracey

as mentioned on https://github.com/facebook/sapling/issues/587 I'm seeing similar, reviewstack versions drop down only has 1 entry despite 4 versions in sidebar and only showing the v1 changes: https://reviewstack.dev/benbrittain/buckle/pull/10 The prs are made and updated with sl pr submit using the gh backed. Sapling version is 0.2.20230523-092610+f12b7eee, gh version 2.31.0 (2023-06-20)

Jun 25 '23 10:06 ahornby

published a couple of PRs that seemed to fix this for me. reviewstack had the version related functions disabled for sapling (rather than ghstack) stacks

Jun 26 '23 19:06 ahornby