react icon indicating copy to clipboard operation
react copied to clipboard

[Transition Tracing] Tracing Marker Deleted

Open lunaruan opened this issue 3 years ago • 1 comments

Stacked Diff. Only Look at this commit

When a tracing marker is deleted:

  • We add {type: 'marker', name: markerName, endTime: time} to the tracing marker's deletions array and call the onMarkerIncomplete callback
  • We also add the same deletion to each parent tracing marker's deletion array and call onMarkerIncomplete on the parents
  • The deleted tracing marker's parent tracing markers can no longer complete, but onMarkerProgress will still be called for subsequent marker updates

lunaruan avatar Jul 19 '22 19:07 lunaruan

Comparing: 992911981bc35b6fc3e7cacb4294d6d782527603...b0791b6fe7f9023f5fd8f1e7e11f56f9157c5525

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js +0.02% 133.01 kB 133.03 kB = 42.65 kB 42.65 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js +0.02% 138.23 kB 138.26 kB = 44.15 kB 44.15 kB
facebook-www/ReactDOM-prod.classic.js +1.20% 468.73 kB 474.33 kB +0.86% 84.30 kB 85.03 kB
facebook-www/ReactDOM-prod.modern.js +1.23% 453.97 kB 459.57 kB +0.88% 82.07 kB 82.79 kB
facebook-www/ReactDOMForked-prod.classic.js +1.20% 468.73 kB 474.33 kB +0.86% 84.30 kB 85.03 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
facebook-www/ReactART-prod.modern.js +1.92% 295.04 kB 300.72 kB +1.42% 51.43 kB 52.16 kB
facebook-www/ReactART-prod.classic.js +1.86% 305.88 kB 311.56 kB +1.36% 53.27 kB 54.00 kB
facebook-www/ReactDOM-prod.modern.js +1.23% 453.97 kB 459.57 kB +0.88% 82.07 kB 82.79 kB
facebook-www/ReactDOMForked-prod.modern.js +1.23% 453.97 kB 459.57 kB +0.88% 82.07 kB 82.79 kB
facebook-www/ReactDOM-prod.classic.js +1.20% 468.73 kB 474.33 kB +0.86% 84.30 kB 85.03 kB
facebook-www/ReactDOMForked-prod.classic.js +1.20% 468.73 kB 474.33 kB +0.86% 84.30 kB 85.03 kB
facebook-www/ReactDOM-profiling.modern.js +1.18% 485.54 kB 491.25 kB +0.84% 86.68 kB 87.40 kB
facebook-www/ReactDOMForked-profiling.modern.js +1.18% 485.54 kB 491.25 kB +0.84% 86.68 kB 87.40 kB
facebook-www/ReactDOM-profiling.classic.js +1.14% 500.36 kB 506.08 kB +0.80% 89.01 kB 89.72 kB
facebook-www/ReactDOMForked-profiling.classic.js +1.14% 500.36 kB 506.08 kB +0.80% 89.01 kB 89.72 kB
facebook-www/ReactART-dev.modern.js +0.77% 805.10 kB 811.30 kB +0.53% 170.55 kB 171.46 kB
facebook-www/ReactART-dev.classic.js +0.76% 815.32 kB 821.52 kB +0.53% 172.68 kB 173.60 kB
facebook-www/ReactDOMForked-dev.modern.js +0.53% 1,176.67 kB 1,182.87 kB +0.36% 258.44 kB 259.36 kB
facebook-www/ReactDOM-dev.modern.js +0.53% 1,176.67 kB 1,182.87 kB +0.36% 258.44 kB 259.36 kB
facebook-www/ReactDOMForked-dev.classic.js +0.52% 1,200.29 kB 1,206.49 kB +0.35% 262.93 kB 263.84 kB
facebook-www/ReactDOM-dev.classic.js +0.52% 1,200.29 kB 1,206.49 kB +0.35% 262.93 kB 263.85 kB

Generated by :no_entry_sign: dangerJS against b0791b6fe7f9023f5fd8f1e7e11f56f9157c5525

sizebot avatar Jul 19 '22 20:07 sizebot