facebook-business-sdk-codegen icon indicating copy to clipboard operation
facebook-business-sdk-codegen copied to clipboard

Published 20 hours ago • verified publisher icon facebook

Resolve php 8.1 deprecations

Open natewiebe13 opened this issue 3 years ago • 7 comments

Related to https://github.com/facebook/facebook-php-business-sdk/pull/554

Checklist

Pull Request Details

Resolves php 8.1 deprecations in a backwards compatible way.

natewiebe13 avatar Jun 08 '22 14:06 natewiebe13

@stcheng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Jun 08 '22 18:06 facebook-github-bot

What's up with this request?

NelinD avatar Jun 14 '22 14:06 NelinD

what's up guys. we are waiting this feature

Ilyasoad avatar Jul 11 '22 07:07 Ilyasoad

We need this too. Up

ryabininea avatar Jul 11 '22 08:07 ryabininea

To make the SDK feature backward compatible with older PHP versions:

  • You have to use #[\ReturnTypeWillChange].
  • And remove use ReturnTypeWillChange

cc @natewiebe13

julionc avatar Jul 26 '22 18:07 julionc

Good call. Updated.

natewiebe13 avatar Jul 26 '22 19:07 natewiebe13

Ping cc @stcheng @jingping2015

julionc avatar Aug 10 '22 19:08 julionc

Wow-wow-wow, what about the merge?

NelinD avatar Oct 28 '22 07:10 NelinD

it's necessary for us, guys

Ilyasoad avatar Oct 28 '22 07:10 Ilyasoad

Why was it closed? Describe the reason for closing the request, pls

ryabininea avatar Oct 28 '22 08:10 ryabininea