SwitchThemeInjector icon indicating copy to clipboard operation
SwitchThemeInjector copied to clipboard

Published 20 hours ago • verified publisher icon exelix11

Suggestion: Apply common.szs to user page too

Open bandithedoge opened this issue 6 years ago • 3 comments

Currently the common.szs option in the injector only applies the diff to common.szs in 0100000000001000 (home menu). The thing is, 0100000000001013 (user page) uses the same file copied to its directory.

bandithedoge avatar May 25 '19 13:05 bandithedoge

Never looked into that file and not sure that's 100% equal, blindly copying files like that could break with fw updates. Guess I could add support for json common patches to user page as well so the json may or may not work without breaking the home menu, even tho idk how useful would that be as the user page isn't really the main focus of themes (and iirc themes still break it)

exelix11 avatar May 25 '19 13:05 exelix11

It is equal, I've been using the same file for both and it works fine. It can be useful for removing the ugly bottom line.

bandithedoge avatar May 25 '19 14:05 bandithedoge

I wanted to add that the common.szs files are not all identical, so indeed blindly copying will break with fw updates.

Migushthe2nd avatar Jun 26 '21 18:06 Migushthe2nd