sphinx-tabs icon indicating copy to clipboard operation
sphinx-tabs copied to clipboard

Published 20 hours ago • verified publisher icon executablebooks

Trim paragraph margins at the bottom of tab panels

Open benjaoming opened this issue 2 years ago • 3 comments

This change affects all themes, however the behavior may also be visually problematic in several themes. I only just noticed it in sphinx-rtd-theme.

Themes that aren't affected probably also aren't affected by the margin change, since in this case they probably don't put margins under p elements.

As I understand sphinx-tabs-panel p:last-child, it will trigger if that particular <p> element is the last of all child elements in the tabs panel. So that should work as intended.

Before: image

After:

image

benjaoming avatar Jan 26 '23 15:01 benjaoming

Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.
Welcome to the EBP community! :tada:

welcome[bot] avatar Jan 26 '23 15:01 welcome[bot]

Just noticed https://github.com/executablebooks/sphinx-tabs/pull/143 - the implementation there wouldn't work for panels with several paragraphs.

benjaoming avatar Jan 26 '23 15:01 benjaoming

Codecov Report

Base: 97.27% // Head: 97.27% // No change to project coverage :thumbsup:

Coverage data is based on head (1feb1f8) compared to base (9431223). Patch has no changes to coverable lines.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #175   +/-   ##
=======================================
  Coverage   97.27%   97.27%           
=======================================
  Files           2        2           
  Lines         220      220           
=======================================
  Hits          214      214           
  Misses          6        6
Flag Coverage Δ
pytests 97.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Jan 26 '23 17:01 codecov[bot]