sphinx-copybutton icon indicating copy to clipboard operation
sphinx-copybutton copied to clipboard

Add minimum requirements

Open sciunto opened this issue 5 years ago • 3 comments

In scikit-image, we discovered that this pluggin is working only for sphinx >= 1.8. Would it be possible to provide the min requirements in a requirements.txt file please?

Thanks a lot! related issue: https://github.com/scikit-image/scikit-image/pull/4604

sciunto avatar Apr 21 '20 07:04 sciunto

Hmmm - that should already be encoded in the package here:

https://github.com/choldgraf/sphinx-copybutton/blob/master/setup.py#L44

That should be used by things like pip when installing.

choldgraf avatar Apr 21 '20 20:04 choldgraf

@choldgraf I think this might be due to the version on conda-forge (of which you might not even know). Anyway this PR sets the proper min version for the version on conda-forge and asks the current maintainer to add the creator of sphinx-copybutton as a maintainer as well 😉

s-weigand avatar Jul 13 '20 00:07 s-weigand

ahh thanks for catching this!

choldgraf avatar Jul 13 '20 15:07 choldgraf