MyST-NB icon indicating copy to clipboard operation
MyST-NB copied to clipboard

Some small adjustments

Open zmoon opened this issue 5 years ago • 8 comments

For https://github.com/executablebooks/MyST-NB/issues/267.

zmoon avatar Oct 03 '20 16:10 zmoon

Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.
Welcome to the EBP community! :tada:

welcome[bot] avatar Oct 03 '20 16:10 welcome[bot]

Some of the mentions of other parts of the code could be cross-references instead of ``text``. I could do that if that is desired.

zmoon avatar Oct 03 '20 16:10 zmoon

Hey @zmoon thanks for the PR, is it ready for review? Since you currently have it set as Draft

chrisjsewell avatar Oct 12 '20 15:10 chrisjsewell

Codecov Report

Merging #268 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #268   +/-   ##
=======================================
  Coverage   87.53%   87.53%           
=======================================
  Files          12       12           
  Lines        1316     1316           
=======================================
  Hits         1152     1152           
  Misses        164      164           
Flag Coverage Δ
#pytests 87.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
myst_nb/render_outputs.py 87.50% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5382280...6d8ca50. Read the comment docs.

codecov[bot] avatar Oct 12 '20 15:10 codecov[bot]

Hi @chrisjsewell I suppose I was waiting to see if there was interest in the cross-references. If not it is ready.

zmoon avatar Oct 12 '20 15:10 zmoon

Oh yeh sorry. Well I won't say no to it, if you have the time 😄

chrisjsewell avatar Oct 12 '20 15:10 chrisjsewell

So I only really found one place where cross-reference made sense. The rest were docutils, which I suppose doesn't work with intersphinx.

zmoon avatar Oct 18 '20 19:10 zmoon

@agoose77, in case you want to clean up the outstanding PRs: The docstring updates in this PR are all outdated (either fixed, or functions have been removed/replaced). Best to close it and the associated issue.

michaelweinold avatar Oct 18 '23 12:10 michaelweinold