MyST-NB
MyST-NB copied to clipboard
Some small adjustments
For https://github.com/executablebooks/MyST-NB/issues/267.
Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.
Welcome to the EBP community! :tada:
Some of the mentions of other parts of the code could be cross-references instead of ``text``. I could do that if that is desired.
Hey @zmoon thanks for the PR, is it ready for review? Since you currently have it set as Draft
Codecov Report
Merging #268 into master will not change coverage. The diff coverage is
n/a.
@@ Coverage Diff @@
## master #268 +/- ##
=======================================
Coverage 87.53% 87.53%
=======================================
Files 12 12
Lines 1316 1316
=======================================
Hits 1152 1152
Misses 164 164
| Flag | Coverage Δ | |
|---|---|---|
| #pytests | 87.53% <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | |
|---|---|---|
| myst_nb/render_outputs.py | 87.50% <ø> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 5382280...6d8ca50. Read the comment docs.
Hi @chrisjsewell I suppose I was waiting to see if there was interest in the cross-references. If not it is ready.
Oh yeh sorry. Well I won't say no to it, if you have the time 😄
So I only really found one place where cross-reference made sense. The rest were docutils, which I suppose doesn't work with intersphinx.
@agoose77, in case you want to clean up the outstanding PRs: The docstring updates in this PR are all outdated (either fixed, or functions have been removed/replaced). Best to close it and the associated issue.