esbuild
esbuild copied to clipboard
evanw
don't leak memory on first incremental build error
Hiya! This is kind of an aside to #1606 and #2280.
Presently, the esbuild server process leaks memory associated with the activeBuild and everything about it if a build({ incremental: true }) fails (rather than a rebuild from it), and there's no way for a user to recover from this.
There's probably a nicer solution that involves giving the rebuild back to the user in the thrown error, but as you've mentioned in https://github.com/evanw/esbuild/issues/1606#issuecomment-924175385, the API gets a bit out of whack then and there's various things to ponder.
A minimally correct solution — at least, one that seems strictly more correct than what we have now, and that doesn't change the API whatsoever — is to rebuild-dispose before calling back with the failure.
