skyline icon indicating copy to clipboard operation
skyline copied to clipboard

Published 20 hours ago • verified publisher icon etsy

Allow for HTTPS Graphite servers.

Open jof opened this issue 12 years ago • 2 comments

If a settings.GRAPHITE_HOST contains an HTTPS Graphite server, this replacement fails. Using a regular expression to allow for both http and https URI protocols.

In the future, perhaps this interpretation should live in settings, rather than in each place in the code?

jof avatar Nov 26 '13 02:11 jof

The webapp javascript needs the scheme wholesale. We could possibly add another setting called GRAPHITE_HOST_SCHEME and use that both here and in the webapp javascript, but I think it's a pretty minor distinction and I'd rather not break folk's settings configurations for it.

astanway avatar Nov 26 '13 02:11 astanway

:+1:

jippi avatar Apr 24 '14 09:04 jippi