libhttpserver icon indicating copy to clipboard operation
libhttpserver copied to clipboard

Published 20 hours ago • verified publisher icon etr

Fix webserver thread safety

Open FlorianChevassu opened this issue 2 years ago • 3 comments

Identify the Bug

https://github.com/etr/libhttpserver/issues/329

Description of the Change

This pull request introduces the usage of locks in the werbserver class in order to protect member variables from data races.

Alternate Designs

N/A

Possible Drawbacks

This might slightly increase response time, but should not be noticeable.

Verification Process

N/A

Release Notes

Fixed an issue where multiple threads did access webserver member variables concurrently, leading to data races.

FlorianChevassu avatar Jul 25 '23 08:07 FlorianChevassu

Overall, it looks good - just a few minor comments

etr avatar Aug 01 '23 14:08 etr

It looks like the PR is failing at compiling

etr avatar Aug 17 '23 20:08 etr

It looks like the PR is failing at compiling

Sorry about the delay. Should be fixed now.

FlorianChevassu avatar Sep 26 '23 08:09 FlorianChevassu