sourcify icon indicating copy to clipboard operation
sourcify copied to clipboard

Add New Chains Syndr 404, 444444

Open vyomshm opened this issue 1 year ago • 4 comments

Add New Chain 404, 444444

Thanks for your pull request to add a new support in Sourcify.

If you haven't done so, please follow the instructions on how to request chain support in docs.

Please check the following items before submitting your pull request for a speedy review.

Checklist

  • [x] The branch is named as add-chain-<chainId>.
  • [x] I haven't modified the chains.json file directly.
  • [x] In sourcify-chains.json file
    • [x] I've set supported: true.
    • [x] I haven't added an rpc field but the one in chains.json is used (if not, please explain why).
  • [x] I've added a test in chain-tests.js file.
  • [x] test-new-chain test in Circle CI is passing.

vyomshm avatar Apr 12 '24 12:04 vyomshm

Could you remove the package-lock.json update from this PR? Other than that it looks fine :)

manuelwedler avatar Apr 12 '24 12:04 manuelwedler

I have removed package json from commit history but one ci test stil seems to be failing. Pls help

@manuelwedler

vyomshm avatar Apr 12 '24 13:04 vyomshm

You now included the changes to chains.json in your commit. Could you rebase your changes on latest staging and only include sourcify-chains-default.json and chain-tests.js?

The node-v16 CI job is expected to fail. Don't worry about that

manuelwedler avatar Apr 12 '24 13:04 manuelwedler

@vyomshm Could you please clean up this PR?

manuelwedler avatar Apr 16 '24 15:04 manuelwedler

Closing due to inactivity. Feel free to open and do the fixes

kuzdogan avatar May 13 '24 12:05 kuzdogan