ERCs icon indicating copy to clipboard operation
ERCs copied to clipboard

Update ERC-6220: fix Import path in EquipRenderUtils.sol

Open vricale opened this issue 1 year ago • 1 comments

EIP-6220: EquipRenderUtils.sol Import Path Fix

This pull request introduces a fix for the import path issue in EquipRenderUtils.sol related to the ERC-6220 standard. Previously, the file incorrectly imported IEquippable.sol, a file that does not exist in the current directory structure. This has been corrected to import IERC6220.sol, aligning with the intended interface usage and resolving the build error HH404.

Changes Made:

Modified import statements in EquipRenderUtils.sol from ../IEquippable.sol to ../IERC6220.sol. Updated interface references from IEquippable to IERC6220 within EquipRenderUtils.sol to reflect the correct interface. Justification: This change is crucial for the successful compilation and execution of the ERC-6220 standard contracts. It ensures that the correct interface is used throughout EquipRenderUtils.sol, thereby aligning with the standard's design and enhancing its interoperability within the Ethereum ecosystem.

Affected Files:

assets/erc-6220/contracts/utils/EquipRenderUtils.sol Tests: Please include a brief description of the testing you performed to validate that this change resolves the issue. If you added any specific unit tests, mention them here.

Authors: Mark [email protected]

vricale avatar Mar 13 '24 09:03 vricale

✅ All reviewers have approved.

eip-review-bot avatar Mar 13 '24 09:03 eip-review-bot

~~As ERC-6220 is already final, it won't be possible to update the naming.~~

Sorry I realized after that it's actually fixing the import path, not just changing to a more consistent name. In that case it seems like errata to me, so I'm okay with the update.

lightclient avatar May 28 '24 11:05 lightclient