EIPs icon indicating copy to clipboard operation
EIPs copied to clipboard

Published 20 hours ago • verified publisher icon ethereum

Update EIP-5216 with address zero control in _approve function like EIP-20

Open ivanmmurciaua opened this issue 3 years ago • 1 comments

After discussing _approve function requires here : https://ethereum-magicians.org/t/last-call-eip-5216-erc1155-approval-by-amount/9898/3 , I'm just updating it

ivanmmurciaua avatar Nov 11 '22 17:11 ivanmmurciaua

Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):

(fail) assets/eip-5216/ERC1155ApprovalByAmount.sol

classification
ambiguous
  • file assets/eip-5216/ERC1155ApprovalByAmount.sol is associated with EIP 5216 but there are no changes being made to corresponding EIP itself. To assure that the change is authorized by the relevant stake-holders, you must also make changes to the EIP file itself for the asset changes to be eligible for auto-merge

eth-bot avatar Nov 11 '22 17:11 eth-bot

I think that this EIP would be ready to final status. Also the deadline is outdated :)

ivanmmurciaua avatar Jan 10 '23 09:01 ivanmmurciaua

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

github-actions[bot] avatar Feb 06 '23 00:02 github-actions[bot]

Ready for a review!

ivanmmurciaua avatar Feb 06 '23 14:02 ivanmmurciaua

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

github-actions[bot] avatar Feb 22 '23 00:02 github-actions[bot]

Yes, review it

ivanmmurciaua avatar Feb 23 '23 20:02 ivanmmurciaua

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

github-actions[bot] avatar Mar 10 '23 00:03 github-actions[bot]

This pull request was closed due to inactivity. If you are still pursuing it, feel free to reopen it and respond to any feedback or request a review in a comment.

github-actions[bot] avatar Apr 22 '23 00:04 github-actions[bot]