EIPs
EIPs copied to clipboard
ethereum
Update EIP-721: broken and mislinked openzeppelin links
In the NFT Implementation and Other Projects column, the 17th link is to openzeppelin, which is already an invalid link and also a link to SafeERC20. openzeppelin has an ERC721 implementation. The link should be to ERC721.sol
ref: https://eips.ethereum.org/EIPS/eip-721#references
Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):
(fail) eip-721.md
| classification |
|---|
updateEIP |
- eip-721.md requires approval from one of (@fulldecent, @dekz, @nastassiasachs)
@SamWilsn @axic @gcolvin @lightclient
How are you? Let us know what you think!
I think my preference for this would be to remove the links entirely. I don't want to establish a precedent of updating broken links in old EIPs.
Should probably be discussed on EIPIP...
@SamWilsn In my opinion, I leave the update or deletion to the outcome of the discussion, but the current situation with the wrong link should be changed.
Even if it were removed, the openzeppelin implementation of EIP-721 would have little impact because it is widely known, but the EIP-721 page does not have a reference implementation like EIP-4907, so newcomers could lose the link to a valuable source of information.
I think my preference for this would be to remove the links entirely. I don't want to establish a precedent of updating broken links in old EIPs.
This is my preference too. However, I would like to establish a precedent for updating broken links in old EIPs. I would just like there to also be a precedent of deleting those old links too.
I understand your basic policy. I will add a commit in the form of a deletion rather than an update to the link.
Please close this PR in favor of https://github.com/ethereum/EIPs/pull/6012
The link to ERC-20 implemented by OpenZeppelin is correct and intentional.
This citation is an important part of the justification of how ERC-721 (and frankly, all) token standards currently work. The text explains the risks of the old ERC-20 behavior and advocates that when transactions fail they should throw, something many now take for granted.
