EIPs icon indicating copy to clipboard operation
EIPs copied to clipboard

Update EIP-1: Add `finalized` date to the preamble

Open xinbenlv opened this issue 3 years ago • 9 comments

Fixes #5488

xinbenlv avatar Aug 21 '22 17:08 xinbenlv

Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):


(fail) eip-1.md

classification
updateEIP
  • Changes to EIP 1 require at least 5 unique approvals from editors; there's currently 1 approvals; the remaining editors are @lightclient, @axic, @samwilsn, @gcolvin

(fail) eip-template.md

classification
ambiguous
  • 'eip-template.md' must be in eip-###.md format; this error will be overwritten upon relevant editor approval

eth-bot avatar Aug 21 '22 17:08 eth-bot

Can this be merged?

xinbenlv avatar Aug 22 '22 01:08 xinbenlv

@SamWilsn thanks for comment. Updated, please review again.

xinbenlv avatar Aug 22 '22 16:08 xinbenlv

@SamWilsn can you re-approve

xinbenlv avatar Aug 23 '22 20:08 xinbenlv

I disagree with this PR.

lightclient avatar Aug 24 '22 02:08 lightclient

@lightclient any concern /revise suggestions?

xinbenlv avatar Aug 24 '22 03:08 xinbenlv

I posted in #5488

lightclient avatar Aug 24 '22 03:08 lightclient

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

github-actions[bot] avatar Sep 14 '22 00:09 github-actions[bot]

Per discussion on today's EIPIP Meeting 66 with @lightclient @SamWilsn @poojaranjan , we are putting on hold this PR in favor of having a new PR(https://github.com/ethereum/EIPs/pull/5755) that adds a upgrade blocknum or upgrade name for Core EIP and then revisit the necessity for having a finalized date.

xinbenlv avatar Oct 05 '22 14:10 xinbenlv

Closing for now until we get new interest in adding a finalized date

xinbenlv avatar Oct 31 '22 21:10 xinbenlv