EIPs icon indicating copy to clipboard operation
EIPs copied to clipboard

Remaining changes moved to 2315.

Open gcolvin opened this issue 3 years ago • 3 comments

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

gcolvin avatar Jul 31 '22 05:07 gcolvin

Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):


(fail) eip-3779.md

classification
updateEIP
  • eip-3779.md is in state withdrawn at the head commit, not draft or last call or review; an EIP editor needs to approve this change
  • This PR requires review from one of [@lightclient, @axic, @samwilsn, @pandapip1]

eth-bot avatar Jul 31 '22 05:07 eth-bot

The commit 5324b5166de9664c13b2648626de0035df34d4e0 (as a parent of 6bfdfb28a5274f3ec233d447def1939d5d1b17ef) contains errors. Please inspect the Run Summary for details.

github-actions[bot] avatar Jul 31 '22 05:07 github-actions[bot]

The commit 6d3a55cfad39a492fbea296d1a17c2e7785fdb3f (as a parent of 75a571ffaa6d1635091524e3c887251629128352) contains errors. Please inspect the Run Summary for details.

github-actions[bot] avatar Jul 31 '22 05:07 github-actions[bot]

I thought Withdrawn EIPs were immutable?

SamWilsn avatar Aug 28 '22 21:08 SamWilsn

I thought Withdrawn EIPs were immutable?

This EIP isn't withdrawn. It is being withdrawn.

Pandapip1 avatar Aug 29 '22 01:08 Pandapip1

Huh... I guess it was already withdrawn?!? It wasn't when I made changes earlier (see https://github.com/ethereum/EIPs/pull/5381/commits/b61c388e7a13b073c2db0ab8237ae228c6ae7283)

Pandapip1 avatar Aug 29 '22 01:08 Pandapip1

So I think what happened here is that two PRs were merged that made the same change, and when I updated the branch, suddenly the changes that appeared to be made in this PR disappeared due to them being in the base branch.

Pandapip1 avatar Aug 29 '22 01:08 Pandapip1

Closing this since it appears to be a duplicate of some other PR.

Pandapip1 avatar Aug 29 '22 01:08 Pandapip1