EIPs icon indicating copy to clipboard operation
EIPs copied to clipboard

EIP-5380: EIP-721 Entitlement Extension

Open Pandapip1 opened this issue 3 years ago • 14 comments
trafficstars

Like EIP-4907 but completely different.

Pandapip1 avatar Jul 31 '22 01:07 Pandapip1

A critical exception has occurred: Message: pr 5380 is already merged; quitting (cc @alita-moore, @mryalamanchi)

eth-bot avatar Jul 31 '22 01:07 eth-bot

The commit 9c8093f17869b62ac4cad828606aa2a29f4a7391 (as a parent of f33551299195c553affeaec02bac0d1348ece390) contains errors. Please inspect the Run Summary for details.

github-actions[bot] avatar Jul 31 '22 01:07 github-actions[bot]

file EIPS/eip-xxxx.md is not a valid filename, but this error has been ignored due to editor approvals

gulp I guess it's lucky there was an eipw error then...

Pandapip1 avatar Jul 31 '22 01:07 Pandapip1

Does the title need to reference EIP4907? Could it just be: ERC-721 User and Expires extension

abcoathup avatar Aug 01 '22 01:08 abcoathup

@TimDaub you wanted this, so here you have it. Any other changes you would have made?

Hey @Pandapip1 thanks so much, I'll try to get this reviewed asap.

TimDaub avatar Aug 01 '22 10:08 TimDaub

The commit d4e54f29b15c87863b42b30cfaf9eb20a35097b9 (as a parent of 665d74f4c01a59a912e79115f21d0204a3b661f7) contains errors. Please inspect the Run Summary for details.

github-actions[bot] avatar Aug 01 '22 18:08 github-actions[bot]

Hey @Pandapip1 thanks so much, I'll try to get this reviewed asap.

No need to do that. I've added myself as an author so I can get this through all the stages ASAP. We're just waiting for the other EIP editors here.

Pandapip1 avatar Aug 01 '22 18:08 Pandapip1

Just realized that if I'm going to be a co-author of this, I might as well make the changes I would have made. Moving to draft as I make changes.

Pandapip1 avatar Aug 02 '22 00:08 Pandapip1

The commit b080cdc2bcd51916dc2a4f9303c18b8e7caf7be1 (as a parent of 690e1126b71c254959570b1461640302f889443a) contains errors. Please inspect the Run Summary for details.

github-actions[bot] avatar Aug 02 '22 16:08 github-actions[bot]

The commit 8c3e20c3b83ffbd92ba77d2c117ad84c8acfaeda (as a parent of 26fdd33db8c49cf3527b714dc400e0341fa5503f) contains errors. Please inspect the Run Summary for details.

github-actions[bot] avatar Aug 02 '22 17:08 github-actions[bot]

@TimDaub would you mind looking at this? It's a lot different than EIP-4907 now, and since I'm including you as an author here I'd like to have your feedback.

Pandapip1 avatar Aug 02 '22 17:08 Pandapip1

The commit 8c3e20c3b83ffbd92ba77d2c117ad84c8acfaeda (as a parent of 97ae56924d486a72f3b6f97a9a25ff525acc8875) contains errors. Please inspect the Run Summary for details.

github-actions[bot] avatar Aug 02 '22 18:08 github-actions[bot]

Hey sorry for taking suuuuper long to get to this. @Pandapip1 thanks so much for taking this on, it looks actually really interesting what you're doing here. I think it is in line with what has been outlined in the Decentralized Society paper, specifically this section:

Screenshot 2022-08-17 at 16 10 55

What do you think about listing a bunch of entitlement types and adding an enum-type structure that captures the entitlement that can be sent to a user?

References:

  • 1: https://papers.ssrn.com/sol3/papers.cfm?abstract_id=4105763

TimDaub avatar Aug 17 '22 14:08 TimDaub

What do you think about listing a bunch of entitlement types and adding an enum-type structure that captures the entitlement that can be sent to a user?

Do you mean add a metadata extension? That does seem like a good idea.

Pandapip1 avatar Aug 17 '22 17:08 Pandapip1

Do you mean add a metadata extension? That does seem like a good idea.

Yeah but preferably it's onchain and e.g. it allows someone to say: "I, address B, entitle address A to 'usus' Property p", where 'usus' is the entitlement and there can be many different ones all encoded in an enum.

TimDaub avatar Aug 28 '22 10:08 TimDaub

Hmm... what about being able to have entitlements extend from other entitlements (i.e. the default address for an entitlement extending from the usus entitlement is the person with the usus entitlement)?

Pandapip1 avatar Aug 28 '22 13:08 Pandapip1

Hmm... what about being able to have entitlements extend from other entitlements (i.e. the default address for an entitlement extending from the usus entitlement is the person with the usus entitlement)?

I think this standards usefulnes can come from doing some research on the possible existing entitlements that exist, naming them appropriately and then recommending them as an enum:

  • usus
  • abusus
  • etc.

TimDaub avatar Sep 03 '22 09:09 TimDaub