EIPs icon indicating copy to clipboard operation
EIPs copied to clipboard

EIP-5252: Account-bound Finance

Open hskang9 opened this issue 3 years ago • 26 comments

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

hskang9 avatar Jul 14 '22 00:07 hskang9

A critical exception has occurred: Message: pr 5252 is already merged; quitting (cc @alita-moore, @mryalamanchi)

eth-bot avatar Jul 14 '22 00:07 eth-bot

The commit 2b3f246f1f81c63ec6904edb3aca131ed8c101f5 (as a parent of ee58e8f8101c1a836ff63e097c6f25581d06d8f9) contains errors. Please inspect the Run Summary for details.

github-actions[bot] avatar Jul 20 '22 08:07 github-actions[bot]

The commit 5b4dacde128f93db6c8e325083340114c6e18783 (as a parent of 2a6bf111f919c12bcf31924c8483ebe7791cba1f) contains errors. Please inspect the Run Summary for details.

github-actions[bot] avatar Jul 20 '22 08:07 github-actions[bot]

The commit ebaf345da63ab44fd1ca2712043519f13c9463d7 (as a parent of d9ae9c5865bdbe3a56852bae6f638c319330e8b4) contains errors. Please inspect the Run Summary for details.

github-actions[bot] avatar Jul 20 '22 08:07 github-actions[bot]

The commit 21569b0b7094577b5d28dc79a5542bb5029bc8f2 (as a parent of 025a99f3f08421290fa052716fdb5d648fb7a3c2) contains errors. Please inspect the Run Summary for details.

github-actions[bot] avatar Jul 20 '22 08:07 github-actions[bot]

The commit d49587b29399dc344ae5331cbe8b7890175e3837 (as a parent of b199e83705ed6f163da3eac5bc711f5a3a9edd97) contains errors. Please inspect the Run Summary for details.

github-actions[bot] avatar Jul 20 '22 08:07 github-actions[bot]

@SamWilsn this is why I don't like the CI commenting.

Pandapip1 avatar Jul 20 '22 17:07 Pandapip1

The commit 2ef1cd1e21b90ead66b366fbd26dcaeda31cd597 (as a parent of 207817e1baf76dd787ea75ecb627cba4e2baa3c7) contains errors. Please inspect the Run Summary for details.

github-actions[bot] avatar Jul 21 '22 14:07 github-actions[bot]

The commit 9fa89a52c6f22509a4cd8afeec8764a5ea7e7399 (as a parent of df6ef33ea88b0228a672b53051085f054697dad6) contains errors. Please inspect the Run Summary for details.

github-actions[bot] avatar Jul 21 '22 14:07 github-actions[bot]

The commit 952f530033e1b6f9769e00bde22f5a23601a7939 (as a parent of 32e307bf67290de9772f9b87bd94a469a2d59307) contains errors. Please inspect the Run Summary for details.

github-actions[bot] avatar Jul 21 '22 15:07 github-actions[bot]

Not sure what went wrong there. I think I was on the wrong commit. I'll hide the outdated comments.

Pandapip1 avatar Jul 21 '22 15:07 Pandapip1

Not sure what went wrong there. I think I was on the wrong commit. I'll hide the outdated comments.

Oops, I was just reviewing your review and saw hidden comments and thought it was a bug/mistake so I unhid them all. 😖 Next time I recommend just deleting them instead, to protect against drive-by Micah.

MicahZoltu avatar Jul 22 '22 05:07 MicahZoltu

The commit f020afb08334fa9b3dcf1fc7326b6c18c4f75749 (as a parent of c0a069a905449fffb8def19af6e020f0874cfbc7) contains errors. Please inspect the Run Summary for details.

github-actions[bot] avatar Jul 22 '22 13:07 github-actions[bot]

The commit 0de933588e23f47d3f17fe1de176c052c4c84357 (as a parent of 213ef960cfc1904a197064a2e249fc96af08e0c3) contains errors. Please inspect the Run Summary for details.

github-actions[bot] avatar Jul 24 '22 08:07 github-actions[bot]

The commit db26852d33f8a402dab7d0357ca1c238f8b18b4a (as a parent of 6eba7db55e6e6f6a14ef230fc0959c8aba2e69d4) contains errors. Please inspect the Run Summary for details.

github-actions[bot] avatar Jul 27 '22 10:07 github-actions[bot]

The commit f61b76d2389022cbe37c1e97b89157e9500ba7a0 (as a parent of 263f4c301f2b269a516db6451a999a9fca188cbd) contains errors. Please inspect the Run Summary for details.

github-actions[bot] avatar Jul 29 '22 05:07 github-actions[bot]

The commit 23b22600a61dee7cf63ec124c3df7a76d3115c8a (as a parent of c552c5e4defcd78e1f4cce5450b3971da2d7a669) contains errors. Please inspect the Run Summary for details.

github-actions[bot] avatar Jul 29 '22 06:07 github-actions[bot]

The commit 1e131c8d0c1537ad334544809daffc44b6b05101 (as a parent of f4c00488498c68de105311b41985ddebddde731b) contains errors. Please inspect the Run Summary for details.

github-actions[bot] avatar Jul 29 '22 06:07 github-actions[bot]

The commit c6555f32f7ac4a8fe7de19d3ea587ebc8c035066 (as a parent of 97895015b4ad624fc41d39e3d5e7bca7b73d7ec3) contains errors. Please inspect the Run Summary for details.

github-actions[bot] avatar Aug 06 '22 14:08 github-actions[bot]

The commit 69277a77b183ca060932a4f07d9a7d94885f455a (as a parent of 1ef76a3cf789e14d8bcef2cc1980ad965fc798c7) contains errors. Please inspect the Run Summary for details.

github-actions[bot] avatar Aug 08 '22 19:08 github-actions[bot]

The commit b1c2231c378f70a47d162dc1ef10ed1db5671a75 (as a parent of 6a71704eadf03625ae09bbbeb7bc40d3154ebe32) contains errors. Please inspect the Run Summary for details.

github-actions[bot] avatar Aug 08 '22 20:08 github-actions[bot]

The commit f3e7bde23f8222b61533846012405e8db2ac2fb0 (as a parent of b150efed164a754b5f116adb66ff602bc0cb5712) contains errors. Please inspect the Run Summary for details.

github-actions[bot] avatar Aug 08 '22 20:08 github-actions[bot]

The commit 2b6e520459da85b89099e476fc234b7b279a93d3 (as a parent of 560d3a140b31b1e20f84777c464a765efc7ecf40) contains errors. Please inspect the Run Summary for details.

github-actions[bot] avatar Aug 08 '22 20:08 github-actions[bot]

The commit e0c60a36432ee98255fa784177c5a47a9c21e048 (as a parent of 97e326ed8b44a9ccbf21b38ed00f29ea28a68911) contains errors. Please inspect the Run Summary for details.

github-actions[bot] avatar Aug 08 '22 20:08 github-actions[bot]

The commit 3e7e1b7d7e2969d953f8aff3c903166104d545ad (as a parent of 74459ca2b8d12c43f8e4cf2eb61aa846afcdac84) contains errors. Please inspect the Run Summary for details.

github-actions[bot] avatar Aug 08 '22 20:08 github-actions[bot]

Please fix the errors. They can be found in the https://github.com/ethereum/EIPs/pull/5252/files tab.

Sure thing. I will fix them by this week.

hskang9 avatar Aug 15 '22 20:08 hskang9

I think I finally understood what you meant. I've made the necessary changes for you.

Thank you for your endeavors to understand the document. I hope your efforts pay off when others come and read this. I appreciate your careful review regardless of non-english background from me.

hskang9 avatar Sep 02 '22 21:09 hskang9

@eth-bot rerun

Pandapip1 avatar Sep 02 '22 21:09 Pandapip1

@xinbenlv Is there anything that needs to be done in the general interface?

hskang9 avatar Sep 04 '22 19:09 hskang9

There isn't anything more that needs to be done. @eth-bot is borking. Let me re-run it.

Pandapip1 avatar Sep 05 '22 12:09 Pandapip1