EIPs icon indicating copy to clipboard operation
EIPs copied to clipboard

Fix SPDX license identifier in EIP-4675

Open Pandapip1 opened this issue 3 years ago • 11 comments

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

Pandapip1 avatar Jul 12 '22 11:07 Pandapip1

A critical and unhandled exception has occurred: Message: not found Data: (there is no data for this error)(cc @alita-moore, @mryalamanchi)

eth-bot avatar Jul 12 '22 11:07 eth-bot

Bump.

Pandapip1 avatar Jul 21 '22 13:07 Pandapip1

Same issue as mentioned here: https://github.com/ethereum/EIPs/pull/5227#issuecomment-1195604313

lightclient avatar Jul 26 '22 15:07 lightclient

The commit acf31d6a62697a48b734472a6ceacc0f05f67350 (as a parent of 967a80971dc331b64be2ea58902783ccd788786f) contains errors. Please inspect the Run Summary for details.

github-actions[bot] avatar Jul 26 '22 16:07 github-actions[bot]

The commit acf31d6a62697a48b734472a6ceacc0f05f67350 (as a parent of 658b654ee6485baa0b65e2318e2f771fc14cd58c) contains errors. Please inspect the Run Summary for details.

github-actions[bot] avatar Jul 28 '22 14:07 github-actions[bot]

The commit 09ad23b8cb74b9947421d034256a875525eeb788 (as a parent of baa7b4841845b0753dc02700a97dfde1360de697) contains errors. Please inspect the Run Summary for details.

github-actions[bot] avatar Aug 11 '22 17:08 github-actions[bot]

The commit 898b08b09840c12f2613a934dd3f980d9ca328ad (as a parent of 318e7fa5d60c15970ac65e94935e7883fac4a6a9) contains errors. Please inspect the Run Summary for details.

github-actions[bot] avatar Aug 12 '22 19:08 github-actions[bot]

Can you elaborate on the reason for changing the license? Unless there is a particular reason, I'm not opposed to changing it. @Pandapip1

PowerStream3604 avatar Aug 13 '22 04:08 PowerStream3604

All assets should be CC0. Exceptions can be made, but in general, assets being the same license as the EIP itself is the policy.

This is primarily to help aid the adoption of your EIP so that people aren't concerned about using your assets due to unfamiliar or incompatible licenses.

Pandapip1 avatar Aug 13 '22 12:08 Pandapip1

@PowerStream3604 please approve this PR

Pandapip1 avatar Aug 17 '22 18:08 Pandapip1

@SamWilsn I request a manual merge.

Pandapip1 avatar Aug 18 '22 00:08 Pandapip1

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

github-actions[bot] avatar Sep 12 '22 00:09 github-actions[bot]

Still an issue.

Pandapip1 avatar Sep 12 '22 12:09 Pandapip1

Needs manual merge due to deleting a file.

Pandapip1 avatar Sep 26 '22 22:09 Pandapip1