EIPs icon indicating copy to clipboard operation
EIPs copied to clipboard

Published 20 hours ago • verified publisher icon ethereum

Update EIP-3267: Fix SPDX license identifier

Open Pandapip1 opened this issue 3 years ago • 20 comments

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

Pandapip1 avatar Jul 12 '22 11:07 Pandapip1

Hi! I'm a bot, and I wanted to automerge your PR, but couldn't because of the following issue(s):

(fail) eip-3267.md

classification
updateEIP
  • eip-3267.md requires approval from one of (@vporton)

(pass) assets/eip-3267/contracts/BaseBidOnAddresses.sol

classification
ambiguous
  • file assets/eip-3267/contracts/BaseBidOnAddresses.sol is associated with EIP 3267; because there are also changes being made to EIPS/eip-3267.md all changes to corresponding assets are also allowed

(pass) assets/eip-3267/contracts/BaseLock.sol

classification
ambiguous
  • file assets/eip-3267/contracts/BaseLock.sol is associated with EIP 3267; because there are also changes being made to EIPS/eip-3267.md all changes to corresponding assets are also allowed

(pass) assets/eip-3267/contracts/BaseRestorableSalary.sol

classification
ambiguous
  • file assets/eip-3267/contracts/BaseRestorableSalary.sol is associated with EIP 3267; because there are also changes being made to EIPS/eip-3267.md all changes to corresponding assets are also allowed

(pass) assets/eip-3267/contracts/BaseSalary.sol

classification
ambiguous
  • file assets/eip-3267/contracts/BaseSalary.sol is associated with EIP 3267; because there are also changes being made to EIPS/eip-3267.md all changes to corresponding assets are also allowed

(pass) assets/eip-3267/contracts/BidOnAddresses.sol

classification
ambiguous
  • file assets/eip-3267/contracts/BidOnAddresses.sol is associated with EIP 3267; because there are also changes being made to EIPS/eip-3267.md all changes to corresponding assets are also allowed

(pass) assets/eip-3267/contracts/DAOInterface.sol

classification
ambiguous
  • file assets/eip-3267/contracts/DAOInterface.sol is associated with EIP 3267; because there are also changes being made to EIPS/eip-3267.md all changes to corresponding assets are also allowed

(pass) assets/eip-3267/contracts/DefaultDAOInterface.sol

classification
ambiguous
  • file assets/eip-3267/contracts/DefaultDAOInterface.sol is associated with EIP 3267; because there are also changes being made to EIPS/eip-3267.md all changes to corresponding assets are also allowed

(pass) assets/eip-3267/contracts/ERC1155/ERC1155.sol

classification
ambiguous
  • file assets/eip-3267/contracts/ERC1155/ERC1155.sol is associated with EIP 3267; because there are also changes being made to EIPS/eip-3267.md all changes to corresponding assets are also allowed

(pass) assets/eip-3267/contracts/ERC1155/ERC1155TokenReceiver.sol

classification
ambiguous
  • file assets/eip-3267/contracts/ERC1155/ERC1155TokenReceiver.sol is associated with EIP 3267; because there are also changes being made to EIPS/eip-3267.md all changes to corresponding assets are also allowed

(pass) assets/eip-3267/contracts/ERC1155/ERC1155WithTotals.sol

classification
ambiguous
  • file assets/eip-3267/contracts/ERC1155/ERC1155WithTotals.sol is associated with EIP 3267; because there are also changes being made to EIPS/eip-3267.md all changes to corresponding assets are also allowed

(pass) assets/eip-3267/contracts/ERC1155/IERC1155.sol

classification
ambiguous
  • file assets/eip-3267/contracts/ERC1155/IERC1155.sol is associated with EIP 3267; because there are also changes being made to EIPS/eip-3267.md all changes to corresponding assets are also allowed

(pass) assets/eip-3267/contracts/ERC1155/IERC1155TokenReceiver.sol

classification
ambiguous
  • file assets/eip-3267/contracts/ERC1155/IERC1155TokenReceiver.sol is associated with EIP 3267; because there are also changes being made to EIPS/eip-3267.md all changes to corresponding assets are also allowed

(pass) assets/eip-3267/contracts/Salary.sol

classification
ambiguous
  • file assets/eip-3267/contracts/Salary.sol is associated with EIP 3267; because there are also changes being made to EIPS/eip-3267.md all changes to corresponding assets are also allowed

(pass) assets/eip-3267/contracts/SalaryWithDAO.sol

classification
ambiguous
  • file assets/eip-3267/contracts/SalaryWithDAO.sol is associated with EIP 3267; because there are also changes being made to EIPS/eip-3267.md all changes to corresponding assets are also allowed

eth-bot avatar Jul 12 '22 11:07 eth-bot

Closing and re-opening to test something unrelated.

Pandapip1 avatar Jul 14 '22 15:07 Pandapip1

Testing in prod moment

Pandapip1 avatar Jul 14 '22 16:07 Pandapip1

Bump.

Pandapip1 avatar Jul 21 '22 13:07 Pandapip1

@Pandapip1 I don't think we can unilaterally convert these licenses as the authors should approve the change.

lightclient avatar Jul 26 '22 15:07 lightclient

The commit 197d5b1412ef6e33f761b6354d41b0c7ba8d8d09 (as a parent of b7cdcd7357663807f16a2d7b73334e3577133bda) contains errors. Please inspect the Run Summary for details.

github-actions[bot] avatar Jul 26 '22 16:07 github-actions[bot]

I agree with @lightclient, these definitely need author approval.

MicahZoltu avatar Jul 27 '22 04:07 MicahZoltu

@Pandapip1 I don't think we can unilaterally convert these licenses as the authors should approve the change.

Agreed. That's why I haven't been merging these w/o author approval, and have been letting @eth-bot handle the majority of the work.

Pandapip1 avatar Jul 27 '22 17:07 Pandapip1

The commit 197d5b1412ef6e33f761b6354d41b0c7ba8d8d09 (as a parent of 6d738128fce30227d49bdb0af209426271d2756c) contains errors. Please inspect the Run Summary for details.

github-actions[bot] avatar Jul 28 '22 14:07 github-actions[bot]

The commit 10f59a088f35938955bfb5afd5f0b6b2f5de57be (as a parent of 94b938d8a239a535dc802b2da14be9e92945dc6d) contains errors. Please inspect the Run Summary for details.

github-actions[bot] avatar Aug 01 '22 15:08 github-actions[bot]

The commit 6f2310ac8e6eb8e9d347c777b459e4fccce8bdf5 (as a parent of 62400f7d52edc5bb36f0545db99efcba16aafcd7) contains errors. Please inspect the Run Summary for details.

github-actions[bot] avatar Aug 11 '22 17:08 github-actions[bot]

The commit 532078d86f66bc1ba99e06858fc058ab71a69ea8 (as a parent of 0fbcb5e8abd48cc0f92c6b5b3b8af2ef779837e8) contains errors. Please inspect the Run Summary for details.

github-actions[bot] avatar Aug 12 '22 19:08 github-actions[bot]

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

github-actions[bot] avatar Sep 12 '22 00:09 github-actions[bot]

Still an issue.

Pandapip1 avatar Sep 12 '22 12:09 Pandapip1

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

github-actions[bot] avatar Oct 11 '22 00:10 github-actions[bot]

Waiting for author review.

Pandapip1 avatar Oct 11 '22 11:10 Pandapip1

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

github-actions[bot] avatar Oct 27 '22 00:10 github-actions[bot]

Waiting for author review.

Pandapip1 avatar Oct 27 '22 12:10 Pandapip1

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

github-actions[bot] avatar Nov 12 '22 00:11 github-actions[bot]

Waiting for review

Pandapip1 avatar Nov 12 '22 00:11 Pandapip1

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

github-actions[bot] avatar Nov 27 '22 00:11 github-actions[bot]

Waiting on author review

Pandapip1 avatar Nov 27 '22 19:11 Pandapip1

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

github-actions[bot] avatar Dec 12 '22 00:12 github-actions[bot]

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

github-actions[bot] avatar Dec 28 '22 00:12 github-actions[bot]

For the author everything seems OK.

vporton avatar Dec 28 '22 18:12 vporton

For the author everything seems OK.

Great! Adding to manual merge queue.

Pandapip1 avatar Jan 04 '23 22:01 Pandapip1