contracts icon indicating copy to clipboard operation
contracts copied to clipboard

feat: Have ExecutionManager pass data up

Open smartcontracts opened this issue 4 years ago • 3 comments

Description Ensures that OVM_ExecutionManager will pass data upwards. Also modifies OVM_ProxyEOA and OVM_SequencerEntrypoint to pass data upwards and out of the EM.

Additional context Vastly simplifies the process of giving users relevant return data in Geth. Cuts a lot of code out of evm.go.

Metadata

  • Fixes roadmap728

smartcontracts avatar Mar 23 '21 00:03 smartcontracts

~~Tests might fail, will fix if they do. Want CI to run in the background while I work on some other stuff.~~ Tests passing.

smartcontracts avatar Mar 23 '21 00:03 smartcontracts

@smartcontracts Can you confirm that this PR is fully backwards compatible?

tynes avatar Mar 25 '21 01:03 tynes

@smartcontracts Can you confirm that this PR is fully backwards compatible?

I do not think this PR is fully backwards compatible. So we're going to have to keep this one open for a little.

smartcontracts avatar Mar 29 '21 18:03 smartcontracts