gofail icon indicating copy to clipboard operation
gofail copied to clipboard

Published 20 hours ago • verified publisher icon etcd-io

Add integration tests for gofail

Open henrybear327 opened this issue 1 year ago • 1 comments

Add integration test for the gofail library.

The idea is to make sure features, such as the one introduced in https://github.com/etcd-io/gofail/pull/65 will not have regression in future changes.

henrybear327 avatar May 14 '24 20:05 henrybear327

/cc @ahrtr the code here is now rebased!

henrybear327 avatar May 17 '24 12:05 henrybear327

Please take a look & fix the workflow failure.

ahrtr avatar May 22 '24 06:05 ahrtr

cc @ArkaSaha30 PTAL

ahrtr avatar May 22 '24 19:05 ahrtr

/cc @serathius

henrybear327 avatar Jun 08 '24 23:06 henrybear327

@ArkaSaha30 Please ping me back when you finish reviewing this PR. thx

ahrtr avatar Jun 09 '24 18:06 ahrtr

LGTM

nice work!

Thanks for all the review comments and suggestions @ahrtr @ArkaSaha30 ! :)

henrybear327 avatar Jun 18 '24 20:06 henrybear327