etcd

etcd copied to clipboard

Based on the experience of performing dependency bumps, some minor improvements are made to the script to make it conform to our current dependency bump procedure, listed as follows:

• print out the dependency's version before and after the bump
• check if the dependency is fully indirect
• change the behavior of bumping dependency (doesn't ignore bumping indirect dependency in the go mod files anymore)
• check if all dependencies across all go mod files have the same pinned version respectively after bumping a dependency

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

Sep 19 '24 17:09 henrybear327

/cc @ivanvc /cc @ahrtr I am not good with bash scripts :(

This is the script that I have been using to bump the dependencies in the past months. Hopefully, it will be helpful for future volunteers before the dependabot is fixed!

Sep 19 '24 17:09 henrybear327

@henrybear327, there are some shellcheck warnings in the script. Would you want to draft the PR? And would you like me to continue on top of it? Or do you want to address the issues?

Sep 19 '24 17:09 ivanvc

@henrybear327, there are some shellcheck warnings in the script. Would you want to draft the PR? And would you like me to continue on top of it? Or do you want to address the issues?

@ivanvc let's draft the PR and you can probably take over it if you have time to improve it!

Hopefully it's a helpful start otherwise you can trash the PR and start from scratch!

Thanks!

Sep 19 '24 17:09 henrybear327

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 69.14%. Comparing base (116caca) to head (340a0bb).

@@            Coverage Diff             @@
##             main   #18609      +/-   ##
==========================================
- Coverage   69.20%   69.14%   -0.07%     
==========================================
  Files         422      422              
  Lines       34821    34821              
==========================================
- Hits        24099    24077      -22     
- Misses       9328     9343      +15     
- Partials     1394     1401       +7     

Sep 19 '24 17:09 codecov-commenter

@henrybear327, there are some shellcheck warnings in the script. Would you want to draft the PR? And would you like me to continue on top of it? Or do you want to address the issues?

@ivanvc I have fixed the shellcheck errors

Maybe you can see if this is a good enough quality script to consider now! Thank you!

Sep 22 '24 15:09 henrybear327

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: henrybear327 Once this PR has been reviewed and has the lgtm label, please assign ivanvc for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Jan 16 '25 21:01 k8s-ci-robot

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions.

Jul 28 '25 00:07 github-actions[bot]

/retest

Sep 12 '25 22:09 henrybear327

Tested with this 20250915's dependency update.

Sep 15 '25 19:09 henrybear327

/retest

Sep 15 '25 19:09 henrybear327

/retest

Sep 15 '25 20:09 henrybear327

/retest

Sep 16 '25 11:09 henrybear327

/retest

Sep 19 '25 20:09 henrybear327

This is looking like a great improvement. It also works great. I left a minimal suggestion for an improvement :)

Thanks for reviewing it! :)

Oct 08 '25 21:10 henrybear327

@henrybear327: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Oct 08 '25 22:10 k8s-ci-robot