etcd icon indicating copy to clipboard operation
etcd copied to clipboard

Published 20 hours ago • verified publisher icon etcd-io

embed: add integration test for distributed tracing

Open VinozzZ opened this issue 3 years ago • 3 comments
trafficstars

To verify distributed tracing feature is correctly setup, this PR adds an integration test for this feature. In the process of writing the test, I discovered a goroutine leak due to the TraceProvider not being closed. This PR fixs this issue as well

Closes #13814

VinozzZ avatar Aug 15 '22 15:08 VinozzZ

Please run ./scripts/fix.sh to fix the mod tidy problems causing a Static Analysis to fail.

ptabor avatar Aug 29 '22 19:08 ptabor

@VinozzZ There are lots of comment changes in this PR. Did you do it intentionally or they are just updated by IDE or any tool? If it's the former (intentionally did), please do it in a separate PR. If it's the latter, please revert the changes.

ahrtr avatar Sep 05 '22 21:09 ahrtr

@VinozzZ There are lots of comment changes in this PR. Did you do it intentionally or they are just updated by IDE or any tool? If it's the former (intentionally did), please do it in a separate PR. If it's the latter, please revert the changes.

This is the change from running ./scripts/fix.sh . Just curious if the script makes changes based on some configs from the local dev machine?

VinozzZ avatar Sep 06 '22 15:09 VinozzZ