common tests framework: cluster client creation with auth could fail

related to #14041

More than 2K line of code change is too big, could you try to break down this PR into small ones?

This PR has 227 additions and 73 deletions.

Signed-off-by: Chao Chen [email protected]

---

In order to fail the test cluster client creation with invalid auth, I have to change the interface function signature.

Does it look better or I can give another shot to split the PR? @ahrtr

mixin test failure is unrelated. There is no monitoring changes.

All the comments are addressed. PTAL, thx! @ahrtr

Codecov Report

Merging #14331 (cd9764a) into main (b886bbc) will decrease coverage by 0.01%. The diff coverage is 82.18%.

:exclamation: Current head cd9764a differs from pull request most recent head 2006d13. Consider uploading reports for the commit 2006d13 to get more accurate results

@@            Coverage Diff             @@
##             main   #14331      +/-   ##
==========================================
- Coverage   75.39%   75.37%   -0.02%     
==========================================
  Files         457      457              
  Lines       37207    37181      -26     
==========================================
- Hits        28053    28026      -27     
- Misses       7394     7397       +3     
+ Partials     1760     1758       -2     

Flag	Coverage Δ
all	75.37% <82.18%> (-0.02%)	:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
client/v3/internal/endpoint/endpoint.go	87.50% <ø> (ø)
client/v3/kv.go	94.44% <ø> (ø)
client/v3/txn.go	100.00% <ø> (ø)
etcdctl/ctlv3/command/global.go	54.40% <0.00%> (ø)
etcdctl/ctlv3/command/make_mirror_command.go	14.28% <0.00%> (ø)
etcdctl/main.go	40.00% <ø> (ø)
pkg/adt/interval_tree.go	87.21% <ø> (ø)
pkg/flags/urls.go	45.00% <0.00%> (ø)
raft/confchange/confchange.go	82.06% <ø> (ø)
raft/tracker/progress.go	97.67% <ø> (ø)
... and 76 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

This PR is accidentally closed because I pushed to the same commit of main to the remote branch. How to re-open it?

This PR is ready to review. Would you mind take a look again? @ahrtr @serathius Thanks!!

Kindly ping again, do you think upstream still needs this auth test migration? @serathius @ahrtr

For faster review I would recommend removing unrelated changes from the PR. It's over 300 lines of code, but still includes changes that muddy the water. Best if PRs do one thing and only this one thing.

For faster review I would recommend removing unrelated changes from the PR. It's over 300 lines of code, but still includes changes that muddy the water. Best if PRs do one thing and only this one.

Makes sense. 300+ lines of code is a burden for PR reviewers. I will try to split into smaller PRs for future bigger PRs going forward.

This PR is already a split from original even bigger PR. sigh^

Please also rebase this PR although there is no conflict.