etcd icon indicating copy to clipboard operation
etcd copied to clipboard

server/etcdmain: add configurable cipher list to gRPC proxy listener

Open dusk125 opened this issue 3 years ago • 1 comments

This PR essentially reopens #13362 cherrypicked onto main and with the requested test.

dusk125 avatar Aug 03 '22 19:08 dusk125

hah now I can :police_officer: you have to commit -s and sign the commit

tjungblu avatar Aug 04 '22 06:08 tjungblu

Please fix the format error, try to run gofmt -w the_file_you_changed

ahrtr avatar Aug 15 '22 00:08 ahrtr

Please also add an item into the changelog-3.6

ahrtr avatar Aug 15 '22 00:08 ahrtr

Codecov Report

Merging #14308 (959ef20) into main (f56e0d0) will decrease coverage by 0.12%. The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main   #14308      +/-   ##
==========================================
- Coverage   75.34%   75.22%   -0.13%     
==========================================
  Files         457      457              
  Lines       37185    37197      +12     
==========================================
- Hits        28016    27980      -36     
- Misses       7405     7447      +42     
- Partials     1764     1770       +6     
Flag Coverage Δ
all 75.22% <50.00%> (-0.13%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/embed/config.go 73.96% <0.00%> (+0.56%) :arrow_up:
server/etcdmain/grpc_proxy.go 61.90% <60.00%> (-0.83%) :arrow_down:
client/pkg/v3/tlsutil/cipher_suites.go 62.50% <0.00%> (-37.50%) :arrow_down:
server/lease/lease.go 94.87% <0.00%> (-5.13%) :arrow_down:
client/v3/leasing/cache.go 87.77% <0.00%> (-3.89%) :arrow_down:
client/pkg/v3/testutil/recorder.go 76.27% <0.00%> (-3.39%) :arrow_down:
server/etcdserver/api/v3rpc/member.go 93.54% <0.00%> (-3.23%) :arrow_down:
pkg/adt/interval_tree.go 84.71% <0.00%> (-2.51%) :arrow_down:
client/v3/leasing/kv.go 89.03% <0.00%> (-2.33%) :arrow_down:
server/etcdserver/api/v3rpc/interceptor.go 75.52% <0.00%> (-2.09%) :arrow_down:
... and 14 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Sep 12 '22 18:09 codecov-commenter

@dusk125 I think we also need this in 3.5 and 3.4 respectively since the report dates back into openshift 4.8

tjungblu avatar Sep 19 '22 08:09 tjungblu