etcd icon indicating copy to clipboard operation
etcd copied to clipboard

v3rpc: memory aware server side throttle

Open geetasg opened this issue 3 years ago • 5 comments

v3rpc: memory aware server side throttle Add a grpc interceptor to enable memory aware server side throttle Design doc - https://docs.google.com/document/d/13OvwDRX1kMah4TKdFmZnYudAxL0zb_piYctKpWj6Rzk/edit#

geetasg avatar May 12 '22 16:05 geetasg

Please paste the URL of design doc, so that others can take a look when they review this PR.

ahrtr avatar May 12 '22 22:05 ahrtr

Codecov Report

Merging #14035 (b826694) into main (5fd6910) will decrease coverage by 0.77%. The diff coverage is 4.47%.

@@            Coverage Diff             @@
##             main   #14035      +/-   ##
==========================================
- Coverage   75.02%   74.24%   -0.78%     
==========================================
  Files         450      451       +1     
  Lines       37210    37411     +201     
==========================================
- Hits        27915    27774     -141     
- Misses       7524     7853     +329     
- Partials     1771     1784      +13     
Flag Coverage Δ
all 74.24% <4.47%> (-0.78%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/v3rpc/rpctypes/error.go 90.47% <ø> (ø)
server/config/config.go 79.76% <ø> (ø)
server/embed/config.go 73.57% <ø> (ø)
server/etcdserver/api/v3rpc/grpc.go 86.48% <0.00%> (-4.95%) :arrow_down:
server/etcdserver/api/v3rpc/interceptor.go 71.70% <0.00%> (-5.90%) :arrow_down:
server/etcdserver/api/v3rpc/qmon.go 0.00% <0.00%> (ø)
server/embed/etcd.go 75.09% <100.00%> (+0.19%) :arrow_up:
server/etcdmain/config.go 85.46% <100.00%> (+0.20%) :arrow_up:
server/etcdserver/api/v3rpc/metrics.go 100.00% <100.00%> (ø)
server/proxy/httpproxy/metrics.go 38.46% <0.00%> (-61.54%) :arrow_down:
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5fd6910...b826694. Read the comment docs.

codecov-commenter avatar May 17 '22 07:05 codecov-commenter

This pr is now set to Open (from Draft) - requesting additional review if any. Thanks. cc @ahrtr

geetasg avatar May 25 '22 23:05 geetasg

@geetasg Could you evaluate the impact on performance? Refer to benchmark

ahrtr avatar May 27 '22 21:05 ahrtr

benchmark

@ahrtr https://docs.google.com/document/d/18MJaQ-u8xWdSeYRCVWFaHDSAXmQAqZyF9ljL0122fjA/edit?usp=sharing - please take a look at these results and let me know if any specific workload should be added. Thanks!

geetasg avatar May 28 '22 04:05 geetasg

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Oct 15 '22 21:10 stale[bot]