etcd

etcd copied to clipboard

Remove ETCD_UNSUPPORTED_ARCH, since the platform is supported. See https://etcd.io/docs/v3.5/op-guide/supported-platform/

CI failure

Step 1/14 : FROM ubuntu:21.10 toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit

I don't know the context on why ETCD_UNSUPPORTED_ARCH was added here. cc @ptabor @spzala Could you maybe find a PR that introduced the env variable here so we can make sure that original purpose is no longer relevant?

@serathius git blame on github help me to identity it.

https://github.com/etcd-io/etcd/pull/12557

Look on the merge commit at that time, arm64 was not supported

https://github.com/etcd-io/etcd/blob/7296a0708c5f25f78ed6e48c28abb8943ecf3fe1/server/etcdmain/etcd.go#L467-L469

Since arm64 is fully supported (https://github.com/etcd-io/etcd/pull/12929) now, I will consider this as leftover.

I'm worried that arm is no longer covered by testing https://github.com/etcd-io/etcd/pull/13181, which means we should consider lowering it's tier.

cc @ptabor @spzala

Reading #13181

Will enable back once the maintenance is done.

Is was only temporary.? Tests should be re-enabled again?

Anyway. s390x is tier 3, but marked a supported. The discussion, if arm64 is tier 2 or tier 3 support does not relevant to this PR.

The Dockerfile for the s390x arch does not have the ENV variable, too.

@serathius What did you think? i guess the discussion about the support tier is not affected by the change. See last post.

Reading #13181

Will enable back once the maintenance is done.

Is was only temporary.? Tests should be re-enabled again?

Those tests run on custom workers provided by one of the maintainers that is no longer active. To re-enable those tests we would need to find an alternative way to get arm64 workers.

Anyway. s390x is tier 3, but marked a supported. The discussion, if arm64 is tier 2 or tier 3 support does not relevant to this PR.

The Dockerfile for the s390x arch does not have the ENV variable, too.

I don't know if the tiers listed on https://etcd.io/docs/v3.5/op-guide/supported-platform/ are up to date. cc @spzala

@ptabor @spzala are you able to provide input here?

I don't know the context on why ETCD_UNSUPPORTED_ARCH was added here. cc @ptabor @spzala Could you maybe find a PR that introduced the env variable here so we can make sure that original purpose is no longer relevant?

@serathius sorry, missed it earlier, here is a related PR - https://github.com/etcd-io/etcd/pull/12557

Reading #13181

Will enable back once the maintenance is done.

Is was only temporary.? Tests should be re-enabled again?

Those tests run on custom workers provided by one of the maintainers that is no longer active. To re-enable those tests we would need to find an alternative way to get arm64 workers.

Anyway. s390x is tier 3, but marked a supported. The discussion, if arm64 is tier 2 or tier 3 support does not relevant to this PR. The Dockerfile for the s390x arch does not have the ENV variable, too.

I don't know if the tiers listed on https://etcd.io/docs/v3.5/op-guide/supported-platform/ are up to date. cc @spzala

Yes, agree. Those tests couldn't be re-enabled for a security reason and cannot be enabled any more.

I'm worried that arm is no longer covered by testing #13181, which means we should consider lowering it's tier.

cc @ptabor @spzala

@serathius yes. I saw you have made doc changes which makes sense, thanks!

Is there a reason, why the sx390 and ppc images are not flagged as unsupported?

I think we just forgot to make it consistent across images. https://github.com/etcd-io/etcd/issues/12543

Okay, I got it. In conclusion, I will close this PR now.