etcd
etcd copied to clipboard
etcd-io
[test] Add test cases to cover the case that client api version is not valid UTF-8 string
This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions.
![stale[bot] avatar](https://avatars.githubusercontent.com/in/1724?v=4 "Published by a pub.dev verified publisher"){kind=small}
This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions.
Hey @ahrtr - I can see this help wanted issue has been open for a while, I'm keen to give it a go.
For the unit test for this would you be adding a new etcdserver/api/v3rpc/interceptor_test.go file or would you include this new test in an existing file elsewhere?
Lastly - can you give me some guidance on how you might approach this, just rough outline/overview would be really helpful as this would be first test case contribution, thanks!
Lastly - can you give me some guidance on how you might approach this, just rough outline/overview would be really helpful as this would be first test case contribution, thanks!
Probably we can intentionally create an invalid version on client side? We might need an e2e or integration test.
Initial pull request covering one scenario is here #15537. I think we need a second test covering a scenario that potentially sidesteps clientv3 altogether.
/assign @jmhbnz
Closing after discussion with maintainers this is not a priority to progress at the moment. We can revisit and reopen in future if that changes.