esp-hal

esp-hal copied to clipboard

Submission Checklist 📝

• [x] I have updated existing examples or added new ones (if applicable).
• [x] My changes were added to the CHANGELOG.md in the proper section.

Extra:

• [x] I have read the CONTRIBUTING.md guide and followed its instructions.

Pull Request Details 📖

Description

See the discussion in #561

have you actually benchmarked this? I'm a bit skeptical this will be faster, since it does a few complex atomic CAS operations.

I haven't yet, I plan on doing some rough benchmarking tomorrow. On single-core SoC's this will most likely be a bit slower, but not taking an all-core global lock (even for a short period) should be beneficial for the multicore SoCs, but we'll see tomorrow. Edit: maybe it might make sense to depend on both and select based on the target.

Another reason to switch was based on this discussion: https://github.com/esp-rs/esp-hal/issues/561#issuecomment-2053974295.

We plan on investigating this a bit further, so just converting to a draft for the time being.

I don't have time to work on this currently so I will close this for now.