erwincoumans

icon indicating a website link http://twitter.com/erwincoumans

icon location NVIDIA, Physics Simulation, Robotics Learning.

Results 99 comments of erwincoumans

fix AABB and inertia calculations

The aabb needs to have the collision margin added for collision detection purposes. Typically the margin is supposed to be a very small value, so does it really impact the...

WIP: More enhancements to DeepMimic (Gym and base env)

Thanks for working on this! Please let me know if it is ready for merge.

New vehicle example

Sorry for not welcoming the contribution, too many issue/PR reports, no team to process it.

Add `format` target to format code using ClangFormat 3.8

Thanks for the contribution, will look at it soon.

Add `format` target to format code using ClangFormat 3.8

trigger CI.

[DRAFT] Fix processInitPoseCommand: must update Aabbs after resetting body pose

Thanks. It is best to just update a single AABB, using the ~~~~~~~~~ world->updateSingleAabb(colObj); ~~~~~~~~~

[DRAFT] Fix processInitPoseCommand: must update Aabbs after resetting body pose

Here is a suggested fix that automatically updates the AABB when using 'resetBasePositionAndOrientation' and 'resetJointState': https://github.com/bulletphysics/bullet3/pull/3311/commits/0196edd4d2e0cde2de5c8138d5f69df2cea9fce4 Exposing a 'performDiscreteCollisionDetection' would be useful too (it would update all aabb's as well...

we should clear the jointTorque that is an external force when

Thanks for the contribution. I need to check and deal with some (broken) unit tests, since the behaviour changes.

Make sure the internal AABB is properly extended.

Thanks Andrea, >> Due to precision loss, sometimes these AABB fails, Could you please provide a small reproduction case that shows the failure? (modify a Bullet example) Will comment on...

Build Windows DLL's

Thanks for the PR. There are a lot of changes and I will need to review each of them, not sure if/when I get to this.