Erwan Pannier

Results 237 comments of Erwan Pannier

Excellent! How can we test it?

@arunavabasu-03 how can this be tested before merging ?

Hello ! I understand what you want. Problem : radis Spectrum are no longer stored with a "medium" key (since https://github.com/radis/radis/pull/51, in 0.9.22) . Calculation and Plotting steps should be...

What do you think of the following fixes : 1. raise a UserError if user specifies "medium" key while giving wavenumber inputs. 2. allow `"nm_air"` as a valid syntax for...

Hello @AllanHOlesenBW, well done for carefully spotting this : the difference between the integrals was indeed due to nm being considered in air. I'll update the test implemented in #455...

Amazing. I think the starting point is the [RovibParFuncCalculator](https://github.com/radis/radis/blob/develop/radis/levels/partfunc.py#L209) class.

Computing our own Dunham will certainly work for diatomics and some linear molecules, but we'll need other models anyway for all the polyatomic molecules. In the end what I had...

Minimal code : (Plotly works much better when giving a DataFrame as input) ``` import pandas as pd import plotly.express as px px.line(pd.DataFrame({'Wavenumber':s.get('radiance_noslit')[0], 'Radiance_noslit':s.get('radiance_noslit')[1]}), x="Wavenumber", y="Radiance_noslit", template='plotly_dark') ``` Renders nice...

Note : RADIS now has a [to_pandas()](https://radis.readthedocs.io/en/latest/source/radis.html#radis.Spectrum.to_pandas) function