shout icon indicating copy to clipboard operation
shout copied to clipboard

Published 20 hours ago • verified publisher icon erming

Upgrade socket.io

Open AlMcKinlay opened this issue 9 years ago • 5 comments

As mentioned in #611 there is a new version of socket.io, but it breaks stuff. We should get that upgraded and fix the breakages, because it fixes a number of issues with reconnecting, which would be good. (also, 1.0 has a really nice feature where it falls back to long-polling immediately before trying websockets, so that people who have websockets blocked on the network can still get stuff immediately rather than waiting for the websockets failure).

AlMcKinlay avatar Jan 27 '16 09:01 AlMcKinlay

I would wait for client dependancies to go through, as there's socket.io client in the repo too.

xPaw avatar Jan 27 '16 09:01 xPaw

There's def a good incentive to upgrade socket.io.

williamboman avatar Jan 27 '16 18:01 williamboman

It would be nice to update socket.io client, there is a bug in the old version that causes crashes.

fknop avatar Apr 01 '16 18:04 fknop

It's up to date in https://github.com/thelounge/lounge/

xPaw avatar Apr 01 '16 18:04 xPaw

@xPaw Thanks, I did not know about this project !

fknop avatar Apr 01 '16 19:04 fknop