restic-automatic-backup-scheduler icon indicating copy to clipboard operation
restic-automatic-backup-scheduler copied to clipboard

`RESTIC_RETENTION_HOURS` is missing from `default.env.sh` file (homebrew macOS)

Open johnsturgeon opened this issue 1 year ago • 6 comments

I just installed via homebrew on my mac and I didn't see the variable: RESTIC_RETENTION_HOURS in the file. I'm wondering if this is an oversight, or if it's intentional for macOS?

johnsturgeon avatar Mar 18 '24 13:03 johnsturgeon

Issue is stale; will soon close.

github-actions[bot] avatar Sep 15 '24 00:09 github-actions[bot]

I recently faced the same issue. After looking into this, I noticed, that the "brew version" still references an old version (7.3.3) where this variable was actually not there (yet). So this repo would need to be updated in order to fix that. Unfortunately IDK how to create a release there, if someone other than the maintainer can do so in the first place (what I also don't know).

d4rkd3v1l avatar Sep 16 '24 07:09 d4rkd3v1l

Hey, for reasons I won’t have computer access for a while, only on my phone. So I’m unable to fix at this point.

As a workaround, you could for my homebrew repo and run the tool chain as described in the README there to build a new bottled release that points to the latest version in this repo :)

erikw avatar Sep 16 '24 07:09 erikw

Thanks for your quick follow up! Alright.. I bumped the version there.

1 workflow awaiting approval This workflow requires approval from a maintainer. [Learn more about approving workflows.]> (https://docs.github.com/actions/managing-workflow-runs/approving-workflow-runs-from-public-forks)

https://github.com/erikw/homebrew-tap/pull/27 https://github.com/erikw/homebrew-tap/pull/28

d4rkd3v1l avatar Sep 16 '24 08:09 d4rkd3v1l

Thank you so much @d4rkd3v1l !

it looks like https://github.com/erikw/homebrew-tap/blob/main/.github/workflows/publish.yml needs to be updated to double quote the git commands, according to that style checker that failed in the PR. Could you maybe make a PR? :).

This must be something new as these GitHub workflows did work in the past.

It’s too cumbersome to fix with a mobile phone, sorry :)

erikw avatar Sep 16 '24 11:09 erikw

Here you go https://github.com/erikw/homebrew-tap/pull/29

d4rkd3v1l avatar Sep 16 '24 12:09 d4rkd3v1l

The Homebrew tap is updated, so the problem should be resolved already!

erikw avatar Feb 08 '25 16:02 erikw