librxvm

librxvm copied to clipboard

An extra null pointer check is not needed in functions like the following.

• inst_stack_cleanup
• rxvm_free
• vm_cleanup

Thanks for that, good point

fixed 54e78752c84e3bb1ca0a93dcae9186d035281a2e

Thanks for your small source code improvement.

Were any update candidates left over for such a change pattern?

No, the check in rxvm_free serves another purpose besides protecting the free(). If compiled->simple is non-NULL, then I know that compiled->exe was never allocated so I don't need to traverse/free it. It needs to stay.

How do you think about to integrate the following small change?

         for (i = 0; i < compiled->size; i++) {
-            if (compiled->exe[i].ccs != NULL)
-                free(compiled->exe[i].ccs);
+            free(compiled->exe[i].ccs);
         }