librxvm icon indicating copy to clipboard operation
librxvm copied to clipboard

Published 20 hours ago • verified publisher icon eriknyquist

reserved identifier violation

Open elfring opened this issue 8 years ago • 3 comments

I would like to point out that identifiers like “_STRING_BUILDER_H_” and “_VMCODE_H_” do not fit to the expected naming convention of the C language standard. Would you like to adjust your selection for unique names?

elfring avatar Oct 15 '17 17:10 elfring

interesting, had not heard of that. Thanks for the recommendation

eriknyquist avatar Oct 15 '17 18:10 eriknyquist

fixed 8f04d2115ae80fa12c321e749a0822428cf50667

eriknyquist avatar Oct 18 '17 05:10 eriknyquist

Thanks for your adjustment of affected include guards.

I would appreciate if these identifiers will not only become standard compliant but also safe for reuse.

elfring avatar Oct 18 '17 12:10 elfring