Erik Welch comments

Results 185 comments of


                                            Erik Welch

Add `nx.config` dict for configuring dispatching and backends

btw, I'm currently dyslexic/confused when it comes to single ` vs double `` when writing docs. Please check the usage of them in this PR and guide me in the...

Test whether function should use Yields instead of Returns

This currently gets tested during the "test / dispatch" CI run. It actually inspects the return type. And, yeah, as docs get updated, the sets will need updated too. The...

Test whether function should use Yields instead of Returns

Thanks for running that experiment @rossbar. I'm glad to be able to compare. > The conclusion I draw from the above experiment is that numpydoc validation is sufficient to catch...

Test whether function should use Yields instead of Returns

Actually, I take back what I said. There is a difference between yielding and returning an iterator. Consider: ```python def f1(): raise ValueError yield from [1, 2] def f2(): raise...

Test whether function should use Yields instead of Returns

Alright, I grouped the function names by whether they are generator functions, return generators, or return iterators. Generator functions is the largest group and should definitely use "Yields" (also, numpydoc...

Test whether function should use Yields instead of Returns

:+1: It looks like `inspect.isgeneratorfunction` is actually pretty limited. It doesn't work on wrapped functions. It only unwraps `__func__` attribute of methods and partial objects. Notably, it ignores `__wrapped__`. It...

Automatically cache results from simple functions

np, I'll try to redo the merge.

Add Python features that started with v3.10 now that v3.9 support is dropped

`zip(x, y, strict=True)` is pretty handy ([see here](https://docs.python.org/3.10/library/functions.html#zip)).

WIP: add `to_backend_graph` and `from_backend_graph`

Thanks for taking a look and asking great questions! > How would this deal with subclasses, eg. DiGraph, MultiGraph without loss of information? Do you mean user-subclasses such as `class...

Dispatch related test failure on main branch when testing locally.

I'm unable to reproduce. @jim22k added this test back in #6628. I expect the following error: ```python-traceback TypeError: Unable to convert inputs and run intersection. intersection() has networkx and nx-loopback...