Eric P Green

Results 103 comments of Eric P Green

> I was wondering if there will be anywhere in the UI for the user to change the preferred language. At the moment we show the window.navigator.language and the user...

Better 👍 Nit: it'd be nice to see a "No search results" message when there are 0 hits. This is a slightly confusing state: ![image](https://github.com/rilldata/rill/assets/14206386/a202c615-996b-45e5-b079-8c7fd9118724)

As mentioned in check-in, first @mindspank will review the UX. After his green light, one of @AdityaHegde / @djbarnwal / myself will do the code review.

Code looks good. I see @jkhwu just finalized the [Time "Superpill" PRD](https://www.notion.so/rilldata/Time-Super-pill-Rearrange-filter-bar-and-selectors-b26f581630a14680b05fb5f2cd2d41e6), so I think her UX feedback will be important.

Nit: looks like it's missing some padding between the Rill icon and the dashboard name Observed: ![image](https://github.com/rilldata/rill/assets/14206386/87755278-c046-463b-b37f-7d29c8b986bf) Design: ![image](https://github.com/rilldata/rill/assets/14206386/a41dd2fb-ae78-482f-a03e-8c44a8f29b6f)

I just tried to reproduce and now I'm getting slightly different buggy behavior. Sorting by a column causes the table to disappear entirely. JAM: https://jam.dev/c/52b0109d-9f1e-4608-be4c-fe6fa99e5964

UXQA – - Given the super pill can turn _on_ a time range comparison, I'd expect to be able to turn _off_ a time range comparison. It feels weird to...

Findings with @AdityaHegde: - This report was created through code. The report does not provide sufficient query arguments to compose a valid query. We should have validation to warn the...

I'd recommend syncing with @mindspank and @jkhwu to get their perspectives on the UX. For background, here's [an old Notion doc](https://www.notion.so/rilldata/Implement-visual-custom-date-range-picker-6c4833af46de4f2f8561fdb8a3cad44a) that explains requirements and the Litepicker choice. I very...

@fredguth, thanks very much for opening this issue and pushing this forward. A few initial thoughts/questions: - Paraglide looks pretty neat. My one hesitation is that it’s very new (still...