Erez Shinan

In your second example, there is a shift/reduce conflict. There is a way to see it: ```python import logging from lark import Lark, logger logger.setLevel(logging.DEBUG) ... parser = Lark(grammar,parser='lalr', debug=True)...

Why did it modify the SVGs? > MyPy can be moved to pre-commit as well It sounds like a good fit for pre-commit. But moved from where? pyupgrade looks nice!...

Probably best to exclude SVGs. > Currently it's sitting in tox.ini. Doesn't it make sense to have it in both? > Pyupgrade will convert % to f-strings That would be...

Only thing I noticed was that the comment in `docs/requirements.txt` is now misplaced due to sorting it.

Parsing the lark grammar is done using LALR, so unless it's thousands of lines, I don't think it will be noticeable. However, reading the file again and again might be...

Iirc, in order to detect changes in imported files, we end up reading and parsing all of the grammars, even when cache=True.

Why not just use regular profile module? Sort by cumulative time and you should see who's at fault here.

I have a version that should be working for LALR, in branch `end_symbol` If anyone wants to test it and let me know how it goes, that would be great!...

The test seems fine. I think the exception happens because some of the new preprocessing code isn't aware that `$` isn't a real terminal (in the sense that it doesn't...

Hi @jisaacstone, I just created a new branch, `end_symbol3`, which merges `end_symbol` with the most recent master. I don't get the same exceptions as you. In fact, everything works perfectly...