gateway

gateway copied to clipboard

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #2029

Feb 21 '24 10:02 shawnh2

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 64.60%. Comparing base (29946b0) to head (c3df6a1). Report is 92 commits behind head on main.

:exclamation: Current head c3df6a1 differs from pull request most recent head 0b4509a. Consider uploading reports for the commit 0b4509a to get more accurate results

@@            Coverage Diff             @@
##             main    #2665      +/-   ##
==========================================
- Coverage   66.51%   64.60%   -1.92%     
==========================================
  Files         161      122      -39     
  Lines       22673    21147    -1526     
==========================================
- Hits        15080    13661    -1419     
+ Misses       6720     6638      -82     
+ Partials      873      848      -25     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Feb 21 '24 10:02 codecov[bot]

LGTM

Maybe also add a test-case where there is some conflict between the gateways?

good point

Feb 21 '24 10:02 shawnh2

LGTM

Maybe also add a test-case where there is some conflict between the gateways?

there is an issue while implementing this test, and it seems related to #2668

Feb 21 '24 14:02 shawnh2

https://github.com/envoyproxy/gateway/pull/2672 is merged, plz go ahead, thanks.

Feb 23 '24 09:02 Xunzhuo

/retest

all the unstable conformance tests will be investigated via https://github.com/envoyproxy/gateway/issues/2269

Feb 24 '24 10:02 shawnh2

hold again before resolving #2520 and #2724

Feb 28 '24 08:02 shawnh2

/retest

Mar 08 '24 01:03 zirain

seems we still facing the same issue as described in https://github.com/envoyproxy/gateway/issues/2520#issuecomment-1968509285, so #2631 should fix this, I'll put this on schedule

Mar 08 '24 03:03 shawnh2

/retest

Mar 13 '24 07:03 shawnh2

seems we still facing the same issue as described in #2520 (comment), so #2631 should fix this, I'll put this on schedule

Fixed! Finally got e2e passed, but this test is little flakey 🤔

Mar 13 '24 08:03 shawnh2

I'd like split this into seperated suite like the upgrade test.

Mar 13 '24 08:03 zirain

/retest

Mar 14 '24 07:03 shawnh2

/retest

Mar 14 '24 15:03 shawnh2

there's a legit error in CI

    	            				/home/runner/work/gateway/gateway/test/e2e/upgrade/eg_upgrade_test.go:57
        	Error:      	Received unexpected error:
        	            	gateways.gateway.networking.k8s.io "same-namespace" is forbidden: unable to create new content in namespace gateway-conformance-infra because it is being terminated
        	Test:       	TestEGUpgrade
        	Messages:   	error creating resource

Mar 14 '24 21:03 arkodg

/retest

Mar 20 '24 06:03 shawnh2

/retest

Mar 20 '24 06:03 shawnh2

/retest

Mar 20 '24 07:03 shawnh2

hey @shawnh2 is this one ready for review ?

Apr 10 '24 10:04 arkodg

hey @shawnh2 is this one ready for review ?

Yes. But this test seems a little unstable.

Apr 10 '24 10:04 shawnh2

hi @arkodg, I think this PR is good to go. If we running into any flakiness caused by this e2e test case, we can submit an issue to report anytime :)

Apr 21 '24 06:04 shawnh2

/retest

Apr 24 '24 06:04 zirain

/retest

Apr 24 '24 06:04 shawnh2

/retest

Apr 24 '24 06:04 shawnh2

/retest

Apr 24 '24 07:04 shawnh2

raise https://github.com/envoyproxy/gateway/issues/3262 to track flaky e2e test: EnvoyShutdown

Apr 24 '24 07:04 shawnh2

/retest

Apr 24 '24 10:04 shawnh2